Recent Posts

Pages: [1] 2 3 4 ... 10
1
Larger Projects / Re: One-way Two-lane road Fun Patch
« Last post by THLeaderH on Today at 03:26:00 AM »
TurfIt, I appreciate your spending of 4 weeks for the code review.
You claimed that
  • Lane fixing/affinity that doesn't seem to do anything at all. Still NO example demonstrating correct behavior.
  • Road trains driving right through each other.
but I have never seen these phenomena as long as I use otrp v12_3. I made a demonstrating video.

As you insisted, I'll read through the whole patch file again. Also, I'll deal with the issues you listed here. However, unfortunately, writing on this forum scatters the issue reports in many messages and thread. Even your great advice will be surely buried by other many many posts on this topic. So I enabled the issues feature of GitHub. With the issues feature of GitHub, you can point out exactly where of the code is problem. Also you can always work with the latest code.
You spent no less than 4 weeks to do such a sensitive code inspection. Please write about  anything you doubt, anything you say huh about, anything you find incomplete, and anything you feel wrong as the issues on GitHub instead of scattering bug reports, writing something ironical, posting a vague indication on the forum, and keeping a great amount of your analysis in your private note, even though you think Git should be in a trash bin. Please make your issue posts as concrete as possible. For example of if ~ else, please point out at least 1 line that is malformed.
Please also use pull requests if you need.

The OTRP repository on GitHub is here. Thank you for your cooperation.
2
Quote
Morevore, there is absolute no way to enter an invalid character in Win32 (since all input comes via Win32 API), nor could a file name ever have an illegal character (they come both too from the Win2 API).
That is not what the checks are there for. They are more there to make sure that some Simutrans programmer later down the line does not mess up string manipulation operations in a way to generate invalid Unicode, eg by accidently injecting non UTF-8 MultiByte code page characters from unwrapped APIs into the UTF-8 file path strings. A Fatal exception being thrown would allow the cause to be immediately apparent, as opposed to generic missing file errors as the IO API tries to process whatever garbage path it turned into.
Quote
Furthermore this even does not compile with MSVC2012.
Very strange. Maybe 2012 has problems with C++98, or the templates cannot deal with argument declared objects. MSVC 2017 had no problem with the code.

I will hopefully fix the MSVC 2012 compile error. Static size allocated buffers is not really a good solution to string production. Even if it is more than sufficient for any possible string it still uses an arbitrary magic number (why 2048 and not 4096 or 1024? the magic number problem...). Since one has access to std::string why not use it when possible?

So far on Windows Simutrans is capable of both seeing and loading a save named "表外漢字表外漢字.sve" (something I pulled randomly off Wikipedia). It also was capable of producing a save named "沓直鳥沓直鳥沓直鳥.sve" from in game (another random string from Wikipedia). The only problem, with my build at least, is that in game it shows up as unknown character boxes. Still at least such a file can be loaded and saved.
3
Incorporated Patches and Solved Bug Reports / Re: Unicode paths
« Last post by prissi on Today at 02:01:32 AM »
Since the DSG patch was submitted, this is aso solved. Sorry, I lost it off the radar. Anyway, both patches were quite similar in it main function, i.e. providing dr_... functions for all file operations needed.
6
Extension Requests / Re: makeobj versions info to console
« Last post by prissi on Today at 01:58:21 AM »
Should work in r8304
7
probably, this error does not occur in the OTRP v12_3 version as it is already fixed.
The last time I tested the latest version, it was giving compatibility problems with my saved game, now, I'm using version 9.0, because this version is not making an error with my saved game. But I will try to recreate this error with the newest version, as you indicated.
8
Execptions in Simutrans are useless, since the thearding GCC is build without exceptions.

Morevore, there is absolute no way to enter an invalid character in Win32 (since all input comes via Win32 API), nor could a file name ever have an illegal character (they come both too from the Win2 API).

Furthermore this even does not compile with MSVC2012.
Code: [Select]
line (921)
U16View const wparam((std::string(portable ? "/P /D=" : "/D=") + path_to_program).c_str());
error
1>simsys.cc(921): error C2784: "std::_String_iterator<_Mystr> std::operator +(_String_iterator<_Mystr>::difference_type,std::_String_iterator<_Mystr>)": template-Argument für "std::_String_iterator<_Mystr>" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xstring(420): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::_String_const_iterator<_Mystr> std::operator +(_String_const_iterator<_Mystr>::difference_type,std::_String_const_iterator<_Mystr>)": template-Argument für "std::_String_const_iterator<_Mystr>" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xstring(288): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::move_iterator<_RanIt> std::operator +(_Diff,const std::move_iterator<_RanIt> &)": template-Argument für "const std::move_iterator<_RanIt> &" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xutility(1947): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::_Array_iterator<_Ty,_Size> std::operator +(_Array_iterator<_Ty,_Size>::difference_type,std::_Array_iterator<_Ty,_Size>)": template-Argument für "std::_Array_iterator<_Ty,_Size>" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xutility(1801): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::_Array_const_iterator<_Ty,_Size> std::operator +(_Array_const_iterator<_Ty,_Size>::difference_type,std::_Array_const_iterator<_Ty,_Size>)": template-Argument für "std::_Array_const_iterator<_Ty,_Size>" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xutility(1662): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::reverse_iterator<_RanIt> std::operator +(_Diff,const std::reverse_iterator<_RanIt> &)": template-Argument für "const std::reverse_iterator<_RanIt> &" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xutility(1226): Siehe Deklaration von 'std::operator +'
1>simsys.cc(921): error C2784: "std::_Revranit<_RanIt,_Base> std::operator +(_Diff,const std::_Revranit<_RanIt,_Base> &)": template-Argument für "const std::_Revranit<_RanIt,_Base> &" konnte nicht von "const char *" hergeleitet werden.
1>          C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\include\xutility(1031): Siehe Deklaration von 'std::operator +'

Since there seems to be really a pressure for getting this right using low paths, well, I submitted this one. -r8303
9
I tested this case with OTRP v12_3 but couldn't reproduce the error. Could you test this with OTRP v12_3?
10
Pak128.Britain-Ex / Re: Demo game - signalling fix
« Last post by jamespetts on Yesterday at 11:27:43 PM »
That is odd - I did not change the overall dimensions of it; perhaps the new transparent rendering has made the edges look different?
Pages: [1] 2 3 4 ... 10