Author Topic: One-way Two-lane road Fun Patch  (Read 23804 times)

0 Members and 1 Guest are viewing this topic.

Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #280 on: October 11, 2017, 02:06:29 PM »
This is a minor update of One-way Two-lane Road Patch, OTRP ver12_3.
This time, the patch file and the executable binaries are simutrans nightly r8301 based, and the patch can be easily integrated to the nightly trunk.
Source code can be seen on git. https://github.com/teamhimeh/simutrans/tree/OTRP

patch:https://drive.google.com/open?id=0B_rSte9xAhLDampoVkdsdE45NFE (This does not include Ribi-Arrow patch.)
~Executable Files~
:simutrans: (The executable binaries include Ribi-arrow patch. Ribi-arrow pak is required. Please download from here and put it into your pakset.)
win:https://drive.google.com/open?id=0B_rSte9xAhLDTnFFanBNeDMzVmM

To use ribi-arrow, add
Code: [Select]
simple_tool[37]=,:into menuconf.tab.
This version can read a save data of ver12.

~How to use this patch~
  • Download ribi-arrow pak and put it into your pakset.
  • Assign an appropriate key to simple tool 37. Add simple_tool[37]=,: into menuconf.tab and you can use ribi-arrow using the colon key.
  • Download an executable file and put it in the directory where simutrans.exe exists.
  • Execute the OTRP file. Please do not overwrite your save data of simutrans standard.

On this version,
  • I did some more fix of the graphic glitch problem.
  • Some duplicated declaration of methods are removed.
  • The issue that overtaking mode selection window sometimes appears is fixed.

I think all bugs I know is now removed. So, I set this version as a candidate for the integration again!
Any bug reports and ideas for improvement are welcome!
« Last Edit: October 14, 2017, 02:16:05 PM by THLeaderH »

Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #281 on: October 14, 2017, 02:14:42 PM »
I found a small but a severe bug - the issue that simutrans often stops by SEGV while loading a game - and fixed it. These are the fixed code and binary.
patch:https://drive.google.com/open?id=0B_rSte9xAhLDNElXMmY4LUFGVXM
binary for windows: https://drive.google.com/open?id=0B_rSte9xAhLDc09PT1phTXphS0U
CHG: simconvoi.cc::L4039

By the way, is anyone doing a code review or something?

Offline TurfIt

Re: One-way Two-lane road Fun Patch
« Reply #282 on: October 15, 2017, 09:16:41 PM »
I think all bugs I know is now removed. So, I set this version as a candidate for the integration again!
Given issues brought up in April are still left unaddressed - hardly...
Logic incomplete and even flagged with TODO's, yet still left.
Road trains driving right through each other.

And then direct request from July ignored - lane fixing/affinity that doesn't seem to do anything at all. Still no example demonstrating correct behavior.

I'd spent 4 weeks with the v11 code. Intended to setup some simple test cases, but got completely bogged in the code instead - can't create a test case for things that make absolutely no sense.
My notes on suspicious code devolve from simply huh's to stuff not fit to post as the WTF'ery factor increases the deeper one looks.  3 weeks later and my mood has not improved.

Since past lists of specific issues were take too literal, no more detailed specifics. I'd suggest reading through the patch file, and the resultant code. Make sure it's complete. Make sure comments make sense, especially after cut'n' paste jobs. Make sure logical conditions make sense, not testing for things already tested for (I even found one testing the same condition in the same if()!). No state changes in query functions (likely the source of my lane fix/affinity issues). Maybe try using this new fangled keyword called 'else'. if(a), if(!a) yeesh. Avoid revenue being affected by traffic conditions - hint lane yielding.

And a quick peek at v12 - refleshing. what? I can't even...




Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #283 on: October 17, 2017, 03:26:00 AM »
TurfIt, I appreciate your spending of 4 weeks for the code review.
You claimed that
  • Lane fixing/affinity that doesn't seem to do anything at all. Still NO example demonstrating correct behavior.
  • Road trains driving right through each other.
but I have never seen these phenomena as long as I use otrp v12_3. I made a demonstrating video.

As you insisted, I'll read through the whole patch file again. Also, I'll deal with the issues you listed here. However, unfortunately, writing on this forum scatters the issue reports in many messages and thread. Even your great advice will be surely buried by other many many posts on this topic. So I enabled the issues feature of GitHub. With the issues feature of GitHub, you can point out exactly where of the code is problem. Also you can always work with the latest code.
You spent no less than 4 weeks to do such a sensitive code inspection. Please write about  anything you doubt, anything you say huh about, anything you find incomplete, and anything you feel wrong as the issues on GitHub instead of scattering bug reports, writing something ironical, posting a vague indication on the forum, and keeping a great amount of your analysis in your private note, even though you think Git should be in a trash bin. Please make your issue posts as concrete as possible. For example of if ~ else, please point out at least 1 line that is malformed.
Please also use pull requests if you need.

The OTRP repository on GitHub is here. Thank you for your cooperation.