Author Topic: [r8293] Load passangers scheduled to go to depot  (Read 278 times)

0 Members and 1 Guest are viewing this topic.

Offline HyperSim

[r8293] Load passangers scheduled to go to depot
« on: September 25, 2017, 06:52:31 AM »
Hello, everyone.

When you set line and insert "Depot" in the middle of schedule like this.



Passangers at stop A believe this bus will go to stop B but the bus will go to depot and passangers will disappear.


I saw the source code (r8293) and found this in simconvoy.cc (l.2890).
I think this part does not work well.

Code: [Select]
if(  grund_t *gr = welt->lookup( schedule->entries[wrap_i].pos )  ) {
if(  gr->get_depot()  ) {
// do not load for stops after a depot
break;
}
}

Thank you.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8793
  • Total likes: 316
  • Helpful: 229
  • Languages: De,EN,JP
Re: [r8293] Load passangers scheduled to go to depot
« Reply #1 on: September 25, 2017, 01:11:43 PM »
It works, but it will not affect already borded passengers.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4247
  • Total likes: 175
  • Helpful: 149
  • Languages: EN, DE, AT
Re: [r8293] Load passangers scheduled to go to depot
« Reply #2 on: September 25, 2017, 02:35:47 PM »
We could unload the train at the last stop before going to the depot.
Parsley, sage, rosemary, and maggikraut.

Offline Leartin

  • Devotee
  • *
  • Posts: 792
  • Total likes: 287
  • Helpful: 44
  • !!!!!This user was banned for double posting!!!!!
  • Languages: DE, EN
Re: [r8293] Load passangers scheduled to go to depot
« Reply #3 on: September 25, 2017, 06:07:35 PM »
We could unload the train at the last stop before going to the depot.

Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?

Offline HyperSim

Re: [r8293] Load passangers scheduled to go to depot
« Reply #4 on: September 26, 2017, 12:25:58 AM »
Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?

I think the latter way is better, but the current way is not so bad.
They should be unloaded at the last stop before depot if it is not so hard to fix.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 4804
  • Total likes: 191
  • Helpful: 108
  • Languages: EN, NO
Re: [r8293] Load passangers scheduled to go to depot
« Reply #5 on: September 26, 2017, 05:20:54 AM »
Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?

If they just disappear, they might as well disappear in the depot as they do already.