The complexity trees add has been a bane for server owners for some time due to increased map transfer times.
The default forest settings for both pak64 and pak128 tend to create too dense of forests IMHO. A few parameter tweaks and the created forests are much better suited for online games - 1/2 the initial file size and still looks good.
But, the real problem is after ~80 years the entire map suddenly get filled with trees - surely this is a bug, but I've not had a chance to track down...
The make public tool can be very useful in server games for making or rebuilding public ways which are useful for other players to use but not used by the responsible company.
No. The tool is called make_stop_public. It should only work for it's original purpose to create public interchange stations. The ability to use it on ways, etc. seems an oversight and should be completely removed to eliminate the exploit of players ending up with no maintenance costs. If necessary, a second tool to create public ways etc could be created, but must be disable-able for a sane multiplayer game.
Related issue: when a player exploits a shell company to make all the ways public, and the shell goes bankrupt, the ways end up owned by 'null' instead of the public player, hence tolls don't even apply! Nice to fix that too...
Also, changes of this magnitude to game mechanics should ideally have a patch posted for comments first.
The tool error string translation constants are being placed in string constants. This is for maintainability as otherwise the same string constant ends up declared in multiple locations so is hard to change and can be error prone with typos or copy mistakes.
Again, such a change should IMHO have had some discussion first... makes it harder to read as you now have to find the string defined somewhere other than where it is used to see what it actually says.
Changes to translated strings are still all but impossible. Simutranslator is a mystery, and whoever admins it for adding new accounts doesn't respond (still waiting after 10+ months...)
I.E. your change to the make_stop_public tooltip breaks (orphans) all existing translations. Also, the base.tab file wasn't updated with the new text.
The added "Trees disabled!" also wasn't put into base.tab.
I plan to apply my last JIT2 revision at some stage after updating it for compatibility before going on to see if the problems with JIT2 can be ironed out. I also intend to hack around with more of the tools, revising code and adding fund checks. I am open to suggestions for minor things as well.
I know I'm still negligent at getting to it. If it only affected JIT2, then go ahead. But it affects electricity overall in JIT0/1 as well, and there was just something in the changes that gives me a gut feeling of being wrong. I'll get there...
The added fund checks are good. (atleast I can get one good comment into my bloody negative post)