Author Topic: One-way Two-lane road Fun Patch  (Read 6608 times)

0 Members and 1 Guest are viewing this topic.

Offline fam621

Re: One-way Two-lane road Fun Patch
« Reply #140 on: March 12, 2017, 11:29:12 AM »
Will this be available for Simutrans Extended, James?

Offline jamespetts

  • Simitrans-Extended project coordinator
  • Devotee
  • *
  • Posts: 14756
  • Total likes: 307
  • Helpful: 143
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: One-way Two-lane road Fun Patch
« Reply #141 on: March 12, 2017, 11:53:10 AM »
Will this be available for Simutrans Extended, James?

Please see above.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8561
  • Total likes: 253
  • Helpful: 226
  • Languages: De,EN,JP
Re: One-way Two-lane road Fun Patch
« Reply #142 on: March 12, 2017, 09:36:18 PM »
I will review the code; but I am currently on the last few day during move houses (for a family of five to another continent). So no quick action before the end of the month, sorry.

Offline jamespetts

  • Simitrans-Extended project coordinator
  • Devotee
  • *
  • Posts: 14756
  • Total likes: 307
  • Helpful: 143
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: One-way Two-lane road Fun Patch
« Reply #143 on: March 13, 2017, 12:25:36 AM »
I will review the code; but I am currently on the last few day during move houses (for a family of five to another continent). So no quick action before the end of the month, sorry.

Goodness, that sounds like hard work. Very best wishes for that!
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #144 on: March 13, 2017, 01:50:05 AM »
Quote
I will review the code; but I am currently on the last few day during move houses (for a family of five to another continent). So no quick action before the end of the month, sorry.
So I have to do refactoring before Prissi reviews my code because Ver8 code is so dirty...
Actually this project was my first time of modifying a big software :-[
Is there anything to do as a reviewee?
« Last Edit: March 13, 2017, 02:04:04 AM by THLeaderH »

Offline Andyh

Re: One-way Two-lane road Fun Patch
« Reply #145 on: March 13, 2017, 03:38:43 PM »
Thank you THLeaderH!  I tested this in a number of different scenarios over the weekend.  It really works very well.  Both player vehicles and city cars behave as expected and very realistically.  I'll leave it to smarter people than me to comment on the code, but from a functionality perspective I would definitely support immediate integration into Simutrans standard.

Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #146 on: March 19, 2017, 11:35:59 AM »
I uploaded a minor update, OTRP ver8.1, on Google Drive. See from here.
This time, the code patch is simutrans nightly r8141 based, and the patch can be easily integrated to the nightly trunk. Source code can be seen on git. https://github.com/teamhimeh/simutrans/tree/OTRP

The aim of this update is adaptation for the latest nightly code, fixing code style, and fixing a minor bug. In ver8, vehicles sometimes fail to avoid head-on crash and block the street. I don't make executable binaries this time.

This version, ver8.1, can read settings.xml and sve data of standard, but cannot read these of past OTRPs. I think this is because there were changes in rdwr methods between r8128 ~ r8141 and that causes conflict. However, I couldn't find the exact reason. Is there any changes in rdwr methods between r8128 ~ r8141?

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2437
  • Total likes: 221
  • Helpful: 85
  • D'oh
    • by An_dz
  • Languages: PT, EN, (it, de)
Re: One-way Two-lane road Fun Patch
« Reply #147 on: March 19, 2017, 01:46:25 PM »
Yes, the 16 bit colour patch. r8134

Offline Commander Noddy

Re: One-way Two-lane road Fun Patch
« Reply #148 on: March 20, 2017, 12:40:05 PM »
The mod is good:) However, when I test it when the patch v8, my bus (set by human player) can't overpass the citycar (default citycar). The bus has already changed into the faster lane. However, the bus suddenly stop and then it can't overpass the citycar until it left the highway. I want to know what is the problem, thanks:)

May The Force Be With You Always!

Offline THLeaderH

Re: One-way Two-lane road Fun Patch
« Reply #149 on: March 21, 2017, 12:35:45 PM »
Quote
The mod is good:) However, when I test it when the patch v8, my bus (set by human player) can't overpass the citycar (default citycar). The bus has already changed into the faster lane. However, the bus suddenly stop and then it can't overpass the citycar until it left the highway. I want to know what is the problem, thanks:)
I can't reproduce the problem. Could you share a video or sve data with the pakset?