James: Thanks for bringing this up again. It is hard to review such big patches (you translate new_world -> new_get_world?). If this change (welt -> world) would help anything, I can throw it in. But there are still 'welt'names objects, (get_weltpos, gui/welt.h etc).
Here is an updated list of terms including 'ware' with proposed translations. This list should not be too controversial:
ware_besch_t -> goods_desc_t (types of goods/freight, e.g., Passenger, Coal)I did not see a conclusion of the discussion for the following ones:
good_reader_t -> goods_reader_t -> add 's'
good_writer_t -> goods_writer_t -> add 's'
warenbauer_t -> goods_manager_t -> to be inline with goods_reader/writer
ware_t --> cargo_t (to be as short as before) - these is freight with destination (e.g., 10 people going to Berlin, 20t of Coal to the north pole)There are get_ware* methods. What to do with them:
ware variables/parameter -> ware (?)
factory_supplier_desc_t::get_ware - type of goods consumed by a factory (dat-file parameter: "inputgood") -> get_input / get_type ?Also haltestelle_t (halts) has quite a few get_ware_* methods.
factory_product_desc_t::get_ware - type of goods produced by a factory (dat-file parameter: "outputgood")-> get_output / get_type ?
vehicle_desc_t::get_ware - type of goods transported by a vehicle (dat-file parameter: "freight"), similar method: vehicle_t::get_cargo_type -> use this name?