Author Topic: Wrong D_EDIT_*  (Read 2405 times)

0 Members and 1 Guest are viewing this topic.

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2593
  • Total likes: 289
  • Helpful: 89
  • D'oh
    • by An_dz
  • Languages: PT, EN, (it, de)
Wrong D_EDIT_*
« on: December 12, 2013, 08:57:10 PM »
There's a problem with D_EDIT_* in gui_theme.cc, the height is wrong when you use non-default sizes for your theme.

This is because it's loaded too early in the code, before arrows heights are finally defined, it should be moved to the bottom after the heights are calculated.

I don't know where it's better to send it to, here I just moved to the very bottom, right before return. I think it's the safest place. There are 2 typos fixed too. ;D

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8752
  • Total likes: 305
  • Helpful: 229
  • Languages: De,EN,JP
Re: Wrong D_EDIT_*
« Reply #1 on: December 12, 2013, 09:43:31 PM »
Well, but then how do you customize it. Its rather goes into the the init from images. Well spotted, thank you.

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2593
  • Total likes: 289
  • Helpful: 89
  • D'oh
    • by An_dz
  • Languages: PT, EN, (it, de)
Re: Wrong D_EDIT_*
« Reply #2 on: December 13, 2013, 02:29:42 PM »
I thought there was no need to customize it through theme.tab because it has to be max(LINESPACE, max(D_ARROW_LEFT_HEIGHT, D_ARROW_RIGHT_HEIGHT) ). It would look strange define a number smaller than LINESPACE.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8752
  • Total likes: 305
  • Helpful: 229
  • Languages: De,EN,JP
Re: Wrong D_EDIT_*
« Reply #3 on: December 13, 2013, 09:42:08 PM »
But larger is certainly an option, or? Like to have easy to touch it with a finger.

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2593
  • Total likes: 289
  • Helpful: 89
  • D'oh
    • by An_dz
  • Languages: PT, EN, (it, de)
Re: Wrong D_EDIT_*
« Reply #4 on: December 13, 2013, 11:52:32 PM »
But then you would have already made a touch arrow. D_ARROW_(LEFT|RIGHT)_HEIGHT
« Last Edit: December 14, 2013, 12:09:37 AM by An_dz »

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8752
  • Total likes: 305
  • Helpful: 229
  • Languages: De,EN,JP
Re: Wrong D_EDIT_*
« Reply #5 on: December 15, 2013, 09:32:04 PM »
If you want editboxes larger than the arrow and linespace, you need this. Or you would get very wide scrollbars. Hmm.

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2593
  • Total likes: 289
  • Helpful: 89
  • D'oh
    • by An_dz
  • Languages: PT, EN, (it, de)
Re: Wrong D_EDIT_*
« Reply #6 on: December 16, 2013, 02:00:19 AM »
But there's no point in not creating big arrows for touch layout. Or how would you choose the player or change building rotation?