[11.10] Popup messages hidden behind buildings

[MCollett]

This is just silly.  Popup messages are part of the interface, not part of the simulated world, and should be displayed in front of everything.  Instead they get hidden behind stations or other buildings.

Best wishes,
Matthew

[Carl]

This behaviour also alters when one fast-forwards -- i.e. sometimes popup messages are partly obscured only when fast-forwarding.

[TurfIt]

This is recently fixed in standard with the multithreaded display routine. But if compiled single threaded, the convoi tool tips will still be obscured for performance reasons.
I believe in experimental, only the simple drawing mode which can be shown when fast forwarding has been multithreaded. The tools tips then truncate at the thread seams - each thread is painting part of the screen.

[jamespetts]

This is recently fixed in standard with the multithreaded display routine. But if compiled single threaded, the convoi tool tips will still be obscured for performance reasons.
I believe in experimental, only the simple drawing mode which can be shown when fast forwarding has been multithreaded. The tools tips then truncate at the thread seams - each thread is painting part of the screen.

Thank you for the explanation - that is most helpful. May I ask: do you know about when this was fixed so that I can track down the relevant commit and backport the fix to the 11.x branch? This is an annoying problem, as Matthew points out.

[TurfIt]

It's embedded in the largish commit adding multithreading to the non simple drawing mode. r6687.

[MCollett]

This is recently fixed in standard with the multithreaded display routine. But if compiled single threaded, the convoi tool tips will still be obscured for performance reasons.

I must admit that I don't see the relevance of threading for this.   Stop names are correctly displayed in front of all buildings; why can't the popups just use the same mechanism as those, regardless of threading model?

Best wishes,
Matthew

[jamespetts]

It is difficult for me to track down revision numbers with the web tools that I use (I tend to use the Github mirror of the SVN): is it the commit with the message, "allow multithreaded rezoom of images"?

[TurfIt]

That's 6721. Which is useful but not for fixing this... You want:
ADD: extend multithreading to main display. ADD: cache for all player...
... colour images
git-svn-id: svn://tron.homeunix.org/simutrans/simutrans/trunk@6687 8aca7d54-2c30-db11-9de9-000461428c89
https://github.com/aburch/simutrans/commit/8f25bc5e995e7917024008ea0c7c05b42d89f679

The display_after() and display_overlay() changes specifically. If merging the whole thing you also need fixes 6690 and 6692. 6708 would also be useful.

[jamespetts]

Thank you very much!

Edit: Looking at the changes, they are so enormous that it strikes me as uneconomic to import them piecemeal: this will have to await a general merger of code, I think.