The International Simutrans Forum

 

Author Topic: Minimap moved to top of window  (Read 7764 times)

0 Members and 1 Guest are viewing this topic.

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2908
  • D'oh
    • by An_dz
  • Languages: pt, en, it, (de)
Minimap moved to top of window
« on: September 05, 2013, 07:34:56 PM »
Here's a patch to move the minimap in the minimap window to the top, buttons are below and they should open their info without moving or enlarging the elements at all. The patch needs optimisation, I'm calling some functions twice to keep sizes and positions synchronized, very hackish.

Here's a gif showing what it is doing:
« Last Edit: November 28, 2013, 03:16:16 AM by An_dz »

Offline Sarlock

  • Devotee
  • *
  • Posts: 1340
  • Languages: EN
Re: Minimap moved to top of window
« Reply #1 on: September 05, 2013, 09:44:16 PM »
Very nice... it has always bothered me to have the map move up and down with menu selections at the top.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9564
  • Languages: De,EN,JP
Re: Minimap moved to top of window
« Reply #2 on: September 07, 2013, 09:43:34 PM »
Since this is a taste issue, are there any more votes up or down?

Offline Yona-TYT ve

  • Devotee
  • *
  • Posts: 1232
    • Simutrans-BLOG
  • Languages: ES
Re: Minimap moved to top of window
« Reply #3 on: September 07, 2013, 10:51:44 PM »
Since this is a taste issue, are there any more votes up or down?
and why not let the creator of pakset what decide this?

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5542
  • Languages: EN, NO
Re: Minimap moved to top of window
« Reply #4 on: September 07, 2013, 10:58:06 PM »
I like that as little as possible jump around, and I don't see anything reasons why it is more favorable to have things above the maps versus below it.
and why not let the creator of pakset what desida?
This is outside the scope of pak sets. It is rather something for skins/themes to decide, though I don't have the impression the new theme system will support such massive flexibility.

Offline ӔO

  • Devotees (Inactive)
  • *
  • Posts: 2345
  • Hopefully helpful
  • Languages: en, jp
Re: Minimap moved to top of window
« Reply #5 on: September 08, 2013, 12:28:33 AM »
I like it.

It is not like the simutrans GUI has any bias to where the menu buttons are located, so why not have the map buttons at the bottom?

Offline Max-Max

  • Coder/patcher
  • *
  • Posts: 670
    • MK Development
  • Languages: SV,EN
Re: Minimap moved to top of window
« Reply #6 on: September 08, 2013, 04:03:15 PM »
I like that as little as possible jump around, and I don't see anything reasons why it is more favorable to have things above the maps versus below it.This is outside the scope of pak sets. It is rather something for skins/themes to decide, though I don't have the impression the new theme system will support such massive flexibility.
We can have a look at this further down the road. As long things are in containers they can be moved around to some extends. The new GUI structure will let GUI controls relate to each other. If all the map buttons and info is within a container it is merely only a question of drawing the button/info container or the map container at the top, as simple as that...

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9564
  • Languages: De,EN,JP
Re: Minimap moved to top of window
« Reply #7 on: September 08, 2013, 10:16:03 PM »
Different dialogues in different pak sets is certainly a way to kill any useful documentation or the ingame help.

"In the map window, you will find so buttons, maybe, often on the top, or bottom ... "

Apart from fixing this in all translations, and helping user but forgot one has a different setting. As translators and writer of documentation are scare resources, I would like to keep all dialogues as similar as possible along all pak sets.

In this case the buttons at the bottom seems to have more fans.

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Minimap moved to top of window
« Reply #8 on: September 09, 2013, 08:54:43 AM »
I agree with prissi that skinning the UI should not change relative position of elements.

I also "vote" for moving the buttons to bottom...

Offline Carl

  • Devotee
  • *
  • Posts: 1600
    • Website
  • Languages: EN
Re: Minimap moved to top of window
« Reply #9 on: September 09, 2013, 09:27:20 AM »
I don't have a strong opinion here. But playing devil's advocate, here's one potential reason *not* to move the buttons. At the moment when one resizes this window, you're directly resizing the map -- since the map lines up with the bottom right drag button. But if you move the buttons there, it gets slightly more difficult to resize the map.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5542
  • Languages: EN, NO
Re: Minimap moved to top of window
« Reply #10 on: September 09, 2013, 04:20:26 PM »
I don't have a strong opinion here. But playing devil's advocate, here's one potential reason *not* to move the buttons. At the moment when one resizes this window, you're directly resizing the map -- since the map lines up with the bottom right drag button. But if you move the buttons there, it gets slightly more difficult to resize the map.

I'd expect the map to change size, not the button area (except width). The view of the world isn't at the bottom of the Simutrans window either, yet that's what you resize when resizing the Simutrans window, not the status bar.

Offline isidoro

  • Devotee
  • *
  • Posts: 1129
Re: Minimap moved to top of window
« Reply #11 on: September 10, 2013, 12:26:55 AM »
Joining Carl in the role of devil's advocate: I see a potential problem with moving the buttons down.  If the dimensions of the screen are small, it is easier that the buttons fall outside it and be unreachable.

It is not a very strong argument, though, since other dialogs have a similar problem.  The dialog of depots couldn't be used at 1024x600 in the last game I played...


Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2908
  • D'oh
    • by An_dz
  • Languages: pt, en, it, (de)
Re: Minimap moved to top of window
« Reply #12 on: September 12, 2013, 12:14:30 PM »
I'd expect the map to change size, not the button area (except width).
The window only resize when you click on the buttons to fit them bellow, if you resize using the resizer the map will resize.

If the dimensions of the screen are small, it is easier that the buttons fall outside it and be unreachable.
That's why I'm thinking in make the dialogs fit the window and then add scroll bars, this would fix multiple dialogs.

The dialog of depots couldn't be used at 1024x600 in the last game I played...
If you remember when I made some changes in the UI I made the depot work on an iPhone screen, but you complained about it being too high. I also made the vehicle dialog smaller too.

Offline isidoro

  • Devotee
  • *
  • Posts: 1129
Re: Minimap moved to top of window
« Reply #13 on: September 13, 2013, 12:01:59 AM »
If you remember when I made some changes in the UI I made the depot work on an iPhone screen, but you complained about it being too high. I also made the vehicle dialog smaller too.

English as a language has a weak point in that "you".  It can be "me" or "everyone" (impersonal).  If you mean the former, frankly I can't remember me complaining about that...

Offline An_dz

  • Web Admin
  • Administrator
  • *
  • Posts: 2908
  • D'oh
    • by An_dz
  • Languages: pt, en, it, (de)
Re: Minimap moved to top of window
« Reply #14 on: September 17, 2013, 02:27:58 PM »
You're right, my bad. First you was you isidoro, the later was everyone.

Offline isidoro

  • Devotee
  • *
  • Posts: 1129
Re: Minimap moved to top of window
« Reply #15 on: September 17, 2013, 10:50:54 PM »
In fact, I thought there were two options, but there were four...  :D   I didn't realize the correct one...

Offline IgorEliezer br

  • Devotee
  • Administrator
  • *
  • Posts: 4087
  • Cake recipes are cool... REALLY!
    • Igor Eliezer Architect and Urban Planner/Arquiteto e Urbanista
  • Languages: PT, EN, AutoLISP, Python
Re: Minimap moved to top of window
« Reply #16 on: September 17, 2013, 11:47:41 PM »
You're right, my bad. First you was you isidoro, the later was everyone.
Portuguese language has pronominal-verb and hidden subject (and "you" has a distinctive plural form too)... but it seems we Brazilians don't bother using either, so we end up using "you" for everything, everybody and every time. :P

EDIT: for the 2nd "you", I'd use "they" to express impersonality.
« Last Edit: September 17, 2013, 11:55:23 PM by IgorEliezer »