r7028 Slow flow of goods

[Ters]

I've started a new pak64 game and set up a line transporting grain from a farm to a brewery about 15 tiles apart. But the farm will only release enough grain load up one cart (10t) with grain at a time, despite the fact that the brewery has a free input capacity of 485 and the farm has full output storage. Only when the first cart has reached it's destination does the farm release grain to fill up the second cart. Behind the in-transit value at the brewery, there is an 8 in parenthesis.

[prissi]

That happens for very little output storage of the farm and low in-transit percentage. What number did you set it to?

[Ters]

The farm has an output storage of 200. Production is 320 per month, which actually doesn't seem to keep up with what little is being delivered, as storage doesn't reach back up to 200 before next cart is loaded.

I haven't set any in-transit percentage, so it is at whatever the default is. The only thing changed in simuconf.tab is allow_buying_obsolete_vehicles.

[prissi]

But then it seems your in-tranit is limited to 8, while output storage is 200. Hence in_transit percentage is then 4% which is not the default of 500%. Hmm, investigating.

[Ters]

I've checked just to be sure. The main simuconf.tab says 0 and pak64 says 500. I certainly don't have any spikes in demand.

Update:
I wonder if this is caused by some suppliers (not connected) being very far away. The map is 2048x2048. I've not been able to reproduce on any other map, but a random selection of industries all show the same symptom. Factory spacing is something I have tweaked a long time ago. That is perhaps saved in settings.xml?

[prissi]

Unless you activated something in your compile, factory distance does not enter. I created some maps and found no issues with in_transit limit (the second number for the in transit goods). There was however an issue with deleting suppliers.

[Ters]

I saw a TRANSIT_DISTANCE macro controlling an #if dealing with code setting max_menge. But I didn't see it in config.default (nor config.template), so I assume it's off.

But I have now noticed that maps are generated just fine. It's after saving and loading them again that the limits are messed up.

[Ters]

I think the revision number in the title is a bit low. I didn't do a complete rebuild, and the file containing the revision number was likely not recompiled, causing the game to display an older revision number. I have now done a clean rebuild (clean didn't delete the exe by the way), and the problem is still there at 7037. Fine before save, wrong after.

[prissi]

ANyway, next nightly should cure the in_transit limiter when a game is reloaded.

[Ters]

Thanks. Now the flow is more or less back to how I'm used to it being. This wasn't code I was familiar with (which is still true for most of the simulation code). But here's a patch to stop a couple of warnings gcc spits out in relevant code.