in-transit numbers thrown off by depot

[A.Badger]

This may be the same as http://forum.simutrans.com/index.php?topic=16804.0 I can retest this once that bug is fixed (or vice versa).  Wanted to open this up separately as the symptoms and method of reproducing are different so I didn't think I should clutter up the other report.

Platform: Fedora 25 Linux x86_64
Version: simutrans nightly r78834b5
Pakset: pak128.britain-ex-nightly also downloaded last night
Savefile: https://toshio.fedorapeople.org/simutrans/counting-intransit-depot.sve

Steps to reproduce:
* Open the save file
* Open a window for the coal merchant at (15, 14), a window for the colliery dock (37, 45), and a window for the east indiaman at (36, 45)
* Note that the in-transit number on the coal merchant is 110 which agrees with the cargo in the east indiaman (110t of coal) (the colliery dock has 0t of coal waiting)
* Send the east indiaman to the depot (** Note: Due to this bug: http://forum.simutrans.com/index.php?topic=16856.0  you may have to send it to the depot by opening the schedule and adding the depot as a stop.  Then select the depot as the stop you want the ship to travel to).
* When the East Indiaman gets to the depot, the in-transit numbers for the coal merchant will fall to zero.
* The colliery appears to respond to this by pushing more coal to the dock to be sent to the coal merchant.
* Around 40t goes to the dock and then the colliery and coal merchant realize that there is no ship connecting them outside of a depot.  The 40t of coal vanishes from the colliery but the coal merchant continues to record the 40t as in-transit.

* If you release the East Indiaman from the depot, telling it to continue on its scheduled route it will reconnect the two industries but the industries won't produce as much coal because they think that 40t are already intransit.

[jamespetts]

Thank you very much for that report. I think that I have found and fixed this; would you be able to re-test (both this and the other in transit bug)? I should be most grateful. Thank you again.

[A.Badger]

Compiled https://github.com/jamespetts/simutrans-extended/commit/e1a8a0c294203287badaf827b260f98efa61ac13  and this bug is now fixed.  Thanks James!  Doesn't look like the other bug is fixed but I haven't created a fresh game for that one yet.  I'll do more testing and then post results to that topic.

[jamespetts]

Excellent, thank you.