The International Simutrans Forum

 

Author Topic: Bug: Inconsistent/bugged way renewal change logic.  (Read 497 times)

0 Members and 1 Guest are viewing this topic.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2496
  • Languages: EN
Bug: Inconsistent/bugged way renewal change logic.
« on: April 23, 2018, 12:06:45 AM »
Currently one cannot downgrade privately owned roads (not public ways) by scheduling them to be renewed with an inferior type. One cannot even change the renewal order on a road from a superior type to its current type. However being private roads one can demolish them freely and immediate renew them to any way type one wants, even mothballed if so desired.

For example the following should all be possible renewal orders for private roads. All involved road types can be assumed available for construction at the time.
  • Cobblestone renew with Cobblestone -> renew with MacAdam (does not work currently, keeps trying to renew with Cobblestone)
  • MacAdam renew with Cobblestone -> renew with MacAdam (does not work currently, keeps trying to renew with Cobblestone)
  • MacAdam renew with MacAdam -> renew with Cobblestone (works)
I am guessing some public way logic has bled across and is effecting private roads.
« Last Edit: May 06, 2018, 05:00:26 PM by DrSuperGood »

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 17636
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Cannot downgrade private roads using automatic renewal.
« Reply #1 on: April 23, 2018, 10:25:37 AM »
If you wish to downgrade, you now need to hold down CTRL as well as SHIFT - this is more consistent with the UI for downgrading immediately, as the default is, without CTRL being held down, only to upgrade.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2496
  • Languages: EN
Re: Bug: Cannot downgrade private roads using automatic renewal.
« Reply #2 on: April 23, 2018, 10:29:25 PM »
Quote
If you wish to downgrade, you now need to hold down CTRL as well as SHIFT - this is more consistent with the UI for downgrading immediately, as the default is, without CTRL being held down, only to upgrade.
Still bugged then...

Railway tracks can be both upgraded and downgraded from any rail type to any rail type by using shift alone.

Shift + Ctrl on roads will allow one to renew roads with downgraded road types, but not restore their renewal to their current type from a superior type. Like wise Shift alone will allow one to downgrade renewal orders from a superior type to any other superior type except the current way type. Hence if one chances renewal orders from their current way type it is impossible to set them back to the current way type.

Completely inconsistent between way types and with roads there clearly is a bug.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 17636
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Cannot downgrade private roads using automatic renewal.
« Reply #3 on: April 23, 2018, 11:38:05 PM »
Thank you for the additional details - I will have to look into this inconsistency in more detail in due course. In the meantime, I should be grateful for people's views as to which behaviour to harmonise the behaviour - requiring CTRL+SHIFT for downgrading on renewal, or downgrading on renewal with SHIFT only despite requiring CTRL for immediate downgrading?

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 17636
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #4 on: May 04, 2018, 11:26:15 PM »
May I ask whether anyone has any views on this user interface issue?

Offline Matthew

  • *
  • Posts: 98
  • Languages: EN, some ZH, DE & SQ
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #5 on: May 05, 2018, 01:44:33 AM »
I don't have strong views because I've never renewed any way yet. But there would seem to be some value in idiot-proofing the UI by forcing players to be specific if they want to downgrade a way by using CTRL+SHIFT. I would speculate that this is the less common choice.

To be honest, the more important thing IMHO is to make sure that the eventual choice is documented in the Keyboard Help, Mouse Help, and various way tool help pages, as they are currently silent on this matter.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 17636
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #6 on: May 05, 2018, 11:28:38 AM »
Thank you for that suggestion: I have now updated the help text accordingly.

Offline Matthew

  • *
  • Posts: 98
  • Languages: EN, some ZH, DE & SQ
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #7 on: May 05, 2018, 09:47:01 PM »
Thank you for that suggestion: I have now updated the help text accordingly.

That's good news! I had no idea that downgrading was possible until I saw this bug report. This will be helpful to many players when Extended comes out of early access.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 17636
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #8 on: June 05, 2018, 08:02:03 PM »
I have now fixed two issues relating to the consistency of downgrading renewals on roads and railways - I should be grateful if anyone could re-test and confirm the fix.

Offline Matthew

  • *
  • Posts: 98
  • Languages: EN, some ZH, DE & SQ
Re: Bug: Inconsistent/bugged way renewal change logic.
« Reply #9 on: June 08, 2018, 08:41:21 AM »
Downgrading appears to be set correctly, although I've not yet seen a road actually renewed to confirm that it takes effect correctly. Thank you for working on this.