Started by ACarlotti, May 06, 2018, 12:08:01 PM
0 Members and 2 Guests are viewing this topic.
Quote from: Ranran on December 14, 2020, 09:28:07 AMThank you for your report. I think I've fixed it. Please confirm.
Quote from: Phystam on December 14, 2020, 04:29:29 AMThis is a small report and is not a bug. After incorporating standard features, the Extended revision has not been shown on the top but the Standard revision.
simutrans-extended: gui/player_frame_t.cc:111: ki_kontroll_t::ki_kontroll_t(): Assertion `player_t::MAX_AI==4' failed.Aborted (core dumped)
Quote from: wlindley on December 14, 2020, 05:04:09 PMI do note that saving and reloading a game resets the player number.
Quote from: jamespetts on December 14, 2020, 11:31:00 AMI am afraid that I cannot reproduce this on my local development version - can anyone else reproduce this?Edit: I can reproduce this on the builds from the Bridgewater-Brunel server, but not locally.Edit 2: This issue also appears in the server browser in-game, with something like an SVN revision number being used instead of the truncated Github hash. This occurs both on versions built locally and those built on the server.
Quote from: wlindley on December 14, 2020, 11:28:22 PMThis is excellent work! The sawmills always being in the forest is a little thing perhaps but enhances the realism. I did test setting "Location=River" for the early textile mills, ironworks and steel mills; that seems to work properly. Better and better!
Quote from: jamespetts on December 15, 2020, 11:25:15 PMAre you able to push these changes to your github branch?
Quote from: jamespetts on December 17, 2020, 11:22:07 PMCan I ask whether this is ready for a final review?
Quote from: Ranran on December 13, 2020, 02:48:41 PM(1) I forgot to mention the added three symbols. If the pakset has those symbols, some text will be replaced with the symbols, saving space.(2) Two type of average speed is only displayed in debug mode. Therefore, the amount of text is smaller in release builds.The symbol dat is here
Quote from: jamespetts on December 18, 2020, 06:49:02 PMAs to the newlists branch, I believe that I have already merged this, as I do not see any option for merging this when I look at my Git GUI.
Quote from: Ranran on December 18, 2020, 10:31:48 PMSymbols should look like this on the station detail dialog if merged correctly, but pak128.britain-ex still doesn't have those symbols.
Quote from: jamespetts on December 18, 2020, 11:58:45 PMCan you issue a pull request since I seem to have trouble merging this in the usual way?
Quote from: jamespetts on December 17, 2020, 11:22:07 PMAs to the acceleration curve chart, if it is an unreasonable amount of work to truncate the graphs so that they do not always end in 0km/h and 0kN, then it is better to have them like this than not.
QuoteCan I ask whether this is ready for a final review? If so, I should be grateful if you could list all the translation texts for this branch.
cd_physics_tabv-t graphf-v graphAcceleration(actual)Acceleration(full load)Acceleration(empty)Running resistancetime_to_top_speed:distance_required_to_top_speed:helptxt_starting_accelerationhelptxt_actual_accelerationhelptxt_v-t_graphhelptxt_f-v_graphAcceleration graph when nothing is loaded on the convoyhelptxt_vt_graph_full_loadhelptxt_fv_graph_tractive_effortTotal force acting in the opposite direction of the convoyhelptxt_acceleration_timehelptxt_acceleration_distanceUnreachable%.2f sec
Quote from: jamespetts on December 19, 2020, 06:27:25 PMMay I suggest that a basic solution would be simply to truncate the graph at 1km/h less than the top speed? One does not look at this graph to find out the vehicle's top speed, and the datum in the graph corresponding with the top speed is incorrect and not of any use to anyone, so truncating it at 1km/h below the top speed, where the data are still useful, would seem to be a better way of dealing with this. Truncating 1km/h below the top speed would then avoid the problem with there being a fixed number of axes.
Quote from: jamespetts on December 20, 2020, 11:41:47 AMHowever, I have noticed one issue: with the "modern" theme (at least), opening the graph tab for the first time leaves part of the buttons cut off:
QuoteAs to saving the dialogue positions, this is a Standard feature; it had not been working fully in Extended as this was implemented in Standard after the divergence with Extended, but there is no Extended specific code here. I cannot now remember where in the code that this is located.
Quote from: jamespetts on December 20, 2020, 12:37:28 PMExcellent - that has fixed the issue, thank you. I have now added English translation texts to this. Can I check whether this is ready for merging or whether you believe that there is further work to be done?
Quote from: Ranran on December 20, 2020, 12:58:34 PMThere are currently no plans to add features related to physical charts. Therefore, it is a break.I think it's ready to be merged. If there is no problem in operation.