The International Simutrans Forum

 

Author Topic: Every time you delete a town, the game crashes  (Read 377 times)

0 Members and 1 Guest are viewing this topic.

Offline thegamer7893 england

  • *
  • Posts: 706
  • Languages: English
Every time you delete a town, the game crashes
« on: August 16, 2018, 08:30:19 PM »
Hi James. Every time you delete a town on this gamesave and you delete either a signalling centre or a station building (which was in the town deleted), the game crashes. Could you look into this for me please?

Save: https://simutrans-germany.com/files/upload/UK2018-2.sve
« Last Edit: August 18, 2018, 10:07:12 AM by SouthernTransport225 »

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18030
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Every time you delete a town, the game crashes
« Reply #1 on: August 17, 2018, 10:26:32 PM »
I am afraid that I am not able to reproduce this. Can I check whether you are using the latest version (i.e. downloaded on the same day as the bug report was posted) and which specific town that you are trying to delete?

Offline thegamer7893 england

  • *
  • Posts: 706
  • Languages: English
[Info about crash] Every time you delete a town, the game crashes
« Reply #2 on: August 18, 2018, 10:07:02 AM »
A number of towns were been deleted for rebuilding and when like I delete a station building (at Ardley for example) or a signalling centre building. The game crashes.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18030
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Every time you delete a town, the game crashes
« Reply #3 on: August 18, 2018, 12:11:51 PM »
Thank you for the report: I think that I have now fixed this. I should be grateful if you could check with to-morrow's nightly build and report whether the problem has been resolved.

Offline ACarlotti

  • *
  • Posts: 299
Re: Every time you delete a town, the game crashes
« Reply #4 on: August 18, 2018, 01:40:12 PM »
James: In your fix you remove the test for "if(!welt->is_destroying())" - why? As I understand it, this test is intended to speed up unloading maps (either on exit or on loading a new map), and I currently see no reason for it to have been removed.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18030
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Every time you delete a town, the game crashes
« Reply #5 on: August 18, 2018, 02:17:20 PM »
This was removed because it duplicated an identical test a few lines up.

Offline ACarlotti

  • *
  • Posts: 299
Re: Every time you delete a town, the game crashes
« Reply #6 on: August 18, 2018, 09:27:40 PM »
Oh, yes. I really should have checked the original file before writing that post, rather than just looking at the diff while waiting for a flight.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18030
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Every time you delete a town, the game crashes
« Reply #7 on: August 18, 2018, 09:30:53 PM »
Oh, yes. I really should have checked the original file before writing that post, rather than just looking at the diff while waiting for a flight.

Don't worry - that's dedication! I hope that you had a good flight.