The International Simutrans Forum

 

Author Topic: Improvement of year-month display (espesially for East Asians)  (Read 311 times)

0 Members and 1 Guest are viewing this topic.

Offline Ranran jp

  • *
  • Posts: 298
  • Languages: ja
Improvement of year-month display (espesially for East Asians)
« on: September 25, 2018, 12:48:19 PM »
Hi. Ranran made a new patch.(´・ω・`)
I believe this is a long-cherished ambition of the East Asian people. Please give them relief! ;)

Here is my Github branch.

This patch is only an improvement of display, and there should be no change in game play.
When playing in English, there should be no change.

In this patch, change the date and time notation in Japanese as follows.
Before:


This notation was strange in Japanese.

After:



Yes, this has recently been implemented in standard.
Change from the standard is, it covers the depot window and construction date, and changes the order of year and month according to show_month setting in simuconf.tab.
The year and the month order is opposite to Western countries even on the depot window.

If show_month=2,5 and 9:


other, same as currently:


I extended simuconf.tab option show_month = 9 .
It is the journey time equivalent indication of the bottom bar same as "show_month=9" but displays the year / month notation in YYYY/MM on the dialog (depot etc) .



I am incorporating and imitating standard's code for this patch and some variables have been changed from German to English according to the current standard's code.
Will these changes interfere with ACarlotti's work?

Converted words are:
karte_ansicht_tmain_view_t
stundenhours



Three translation texts are added by this patch.
It is for year/month/day symbol - (年/月/日).
It is same as Standard and recommended not to set anything except translated Japanese/Chinese(YYYY年MM月 style).

I attach .dat file for Simutranlator.

Offline ACarlotti

  • *
  • Posts: 316
Re: Improvement of year-month display (espesially for East Asians)
« Reply #1 on: September 25, 2018, 10:05:44 PM »
Will these changes interfere with ACarlotti's work?

At a glance it seems that it probably won't make things harder, although I cannot be sure about this without investigating in far more detail than is worth doing. I think the main source of problems caused by out-of-order porting are when two changes affect the same code, and the second one has been ported first. In those cases I have to look at the version history of that code snippet to work out the history, and thus what or how much needs to be ported (except for the case of translations, where it is often fairly easy to recognise the translation as a separate change even if it's been reordered).

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18227
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Improvement of year-month display (espesially for East Asians)
« Reply #2 on: September 25, 2018, 10:22:34 PM »
Excellent - thank you for that: now incorporated (including Simutranslator changes).

Offline Ranran jp

  • *
  • Posts: 298
  • Languages: ja
Re: Improvement of year-month display (espesially for East Asians)
« Reply #3 on: September 27, 2018, 02:24:30 PM »
Thank you for the incorporating. :)
show_month = 9 will be displayed like this even in English.

In some countries it will be useful, I think. ;)

At a glance it seems that it probably won't make things harder
@ACarlotti - Thank you for your reply.
I hope it will not be difficult.