News:

Use the "Forum Search"
It may help you to find anything in the forum ;).

Improvement of year-month display (espesially for East Asians)

Started by Ranran(retired), September 25, 2018, 12:48:19 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

Hi. Ranran made a new patch.(´・ω・`)
I believe this is a long-cherished ambition of the East Asian people. Please give them relief! ;)

Here is my Github branch.

This patch is only an improvement of display, and there should be no change in game play.
When playing in English, there should be no change.

In this patch, change the date and time notation in Japanese as follows.
Before:


This notation was strange in Japanese.

After:



Yes, this has recently been implemented in standard.
Change from the standard is, it covers the depot window and construction date, and changes the order of year and month according to show_month setting in simuconf.tab.
The year and the month order is opposite to Western countries even on the depot window.

If show_month=2,5 and 9:


other, same as currently:


I extended simuconf.tab option show_month = 9 .
It is the journey time equivalent indication of the bottom bar same as "show_month=9" but displays the year / month notation in YYYY/MM on the dialog (depot etc) .




I am incorporating and imitating standard's code for this patch and some variables have been changed from German to English according to the current standard's code.
Will these changes interfere with ACarlotti's work?

Converted words are:



karte_ansicht_tmain_view_t
stundenhours




Three translation texts are added by this patch.
It is for year/month/day symbol - (年/月/日).
It is same as Standard and recommended not to set anything except translated Japanese/Chinese(YYYY年MM月 style).

I attach .dat file for Simutranlator.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

ACarlotti

Quote from: Ranran on September 25, 2018, 12:48:19 PM
Will these changes interfere with ACarlotti's work?

At a glance it seems that it probably won't make things harder, although I cannot be sure about this without investigating in far more detail than is worth doing. I think the main source of problems caused by out-of-order porting are when two changes affect the same code, and the second one has been ported first. In those cases I have to look at the version history of that code snippet to work out the history, and thus what or how much needs to be ported (except for the case of translations, where it is often fairly easy to recognise the translation as a separate change even if it's been reordered).

jamespetts

Excellent - thank you for that: now incorporated (including Simutranslator changes).
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Thank you for the incorporating. :)
show_month = 9 will be displayed like this even in English.

In some countries it will be useful, I think. ;)

Quote from: ACarlotti on September 25, 2018, 10:05:44 PMAt a glance it seems that it probably won't make things harder
@ACarlotti - Thank you for your reply.
I hope it will not be difficult.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)