The International Simutrans Forum

 

Author Topic: Build error under Haiku due to missing ',' in simsys.cc (line 407)  (Read 550 times)

0 Members and 1 Guest are viewing this topic.

Offline taos

  • *
  • Posts: 19
Some time between 120.2.2 and 120.3 (commit 69ee10ff4bf1643562000a97b6becb47c1f79175 in github), compiling Simutrans under Haiku stopped working. Today I (finally) had some time to look for the reason and it seems it's due to a missing ',' at the end of a line inside a Haiku specific conditional #ifdef statement (probably the reason no other operating system is affected). It's in line 407 of simsys.cc, instead of
Code: [Select]
#elif defined __HAIKU__
"/boot/system/non-packaged/data/fonts/",
"/boot/home/config/non-packaged/data/fonts/",
"~/config/non-packaged/data/fonts/",
"/boot/system/data/fonts/ttfonts/"
it should be
Code: [Select]
#elif defined __HAIKU__
"/boot/system/non-packaged/data/fonts/",
"/boot/home/config/non-packaged/data/fonts/",
"~/config/non-packaged/data/fonts/",
"/boot/system/data/fonts/ttfonts/",

Do you need me to attach a patch?

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4587
  • Languages: EN, DE, AT
Re: Build error under Haiku due to missing ',' in simsys.cc (line 407)
« Reply #1 on: January 05, 2019, 02:09:18 PM »
thank you, committed in r8648

Offline taos

  • *
  • Posts: 19
Re: Build error under Haiku due to missing ',' in simsys.cc (line 407)
« Reply #2 on: January 05, 2019, 07:23:22 PM »
Thanks! BTW, there's another ',' missing in the following linux/BSD/unix section (line 412) which probably didn't negatively affect building on linux because it's not the last one.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4587
  • Languages: EN, DE, AT
Re: Build error under Haiku due to missing ',' in simsys.cc (line 407)
« Reply #3 on: January 06, 2019, 10:22:24 AM »
Thanks for spotting. Will fix.