The International Simutrans Forum

 

Author Topic: Adjustment of message window layout  (Read 514 times)

0 Members and 1 Guest are viewing this topic.

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Adjustment of message window layout
« on: December 25, 2018, 05:49:00 AM »
Merry something again. I brought a patch.
Here is my github branch.

When I translated some game text, I noticed the collapse of the message window layout. (´・ω・`)


It does not collapse in standard.


I tried fixing the code related to this.
Many were changed like standard's.
The deleted part will take over on base_infowin_t::base_infowin_t.


This fix will widen the some information window slightly rather than the previous extended but same as the standard.
(ground info, signal info, citybuilding info by using inspection tool.)

One on the top is currently, on the middle and bottom are modified version.



I think this width is based on the Message centre window.
In citybuilding information etc. Extended has more information amount (number of lines) than standard, so it may feel that the window is large.

Is this an acceptable change? (about width)

EDIT:
Now extended only the message window size.
« Last Edit: December 26, 2018, 09:28:06 AM by Ranran »

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18683
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Adjustment of message window layout
« Reply #1 on: December 25, 2018, 06:04:40 PM »
Thank you for your work on that. The message window changes certainly seem sensible (and I will remove the manual line breaks in some of the text for these, too, since they seem now to be redundant).

I wonder whether it is possible to change the message windows without changing the width of the ground window? There is a fair bit of wasted space in the new version of that window. If this is not possible (or not possible without an unreasonable amount of work), your patch can be incorporated as it is, but it would be preferable not to have wasted space in the ground information window if we can avoid it.

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Adjustment of message window layout
« Reply #2 on: December 25, 2018, 11:58:17 PM »
EDIT1:
I noticed that there was a problem with standard's way.
The size of the image is not taken into consideration, causing problems with 256 size etc. So I will make modification.

EDIT2:
Now extended only the message window size. It does not affect other windows.
« Last Edit: December 26, 2018, 09:30:39 AM by Ranran »

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18683
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Adjustment of message window layout
« Reply #3 on: December 26, 2018, 01:35:03 PM »
Splendid, thank you for letting me know. Testing this shows that there is only a small change in the dialogue for grounds/buildings/etc., so I have incorporated this, as the messages are much easier to read now.

Thank you for your work!

Offline Phystam jp

  • *
  • Posts: 228
  • Pak256.Ex developer
  • Languages: JP, EN, EO
Re: Adjustment of message window layout
« Reply #4 on: December 28, 2018, 04:29:24 AM »
Thank you for your work! I also know this issue with 256-size pakset, but I have no time to fix.