The International Simutrans Forum

 

Author Topic: Passengers evaluation icon on station information window  (Read 2969 times)

0 Members and 1 Guest are viewing this topic.

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #35 on: January 25, 2019, 05:09:57 PM »
Showing the absolute numbers is imho more interesting, as the percentage can be roughly estimated from the color bar.
Also I would prefer putting all the numbers in one line to save vertical space.
I agree with that point. The problem was the width when the number grew.

This is a composite image to check the margin.

How about this layout?

Offline wlindley us

  • Devotee
  • *
  • Posts: 970
    • Hacking for fun and profit since 1977
  • Languages: EN, DE
Re: Passengers evaluation icon on station information window
« Reply #36 on: January 25, 2019, 08:46:51 PM »
The all-icon version is excellent, although it could use a bit more vertical space below the "Evaluation" label and between the line groups. 

Offline Ves

  • Devotee
  • *
  • Posts: 1664
  • Languages: EN, SV, DK
Re: Passengers evaluation icon on station information window
« Reply #37 on: January 26, 2019, 11:08:04 AM »
I agree with that point. The problem was the width when the number grew.

This is a composite image to check the margin.

How about this layout?
I like this layout alot! If it works with numbers, then I do think it is fine. A quick note that it appears you have one single space to the left of the passenger and mail icons, that technically could be more useful among the evaluation entries.
Also, the icon you have now instead of the smiley I think works great, even bether than the previous smiley did!
You made the green bar darker on the passenger evaluation than it is on mail evaluation, may I ask why they are not the same green? The darker one sure does look less "in your face" than the light green, so perhaps changing the mail green to the passenger green?
What about the red color, is there a red that does not shine as much to accompany the darker green?

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #38 on: January 28, 2019, 02:38:29 PM »
At first glance, is the opinion that you guys want to change Happy face :) to Green one advantageous?


You made the green bar darker on the passenger evaluation than it is on mail evaluation, may I ask why they are not the same green?
It is not necessary to distinguish the color of the bar by passengers and mail, but it is necessary to distinguish it in the chart.



The mail icon is a color of green check and the yellow of the mail, so I made it look like a mix.
Should it be used the same green and red on the bar? I would like everyone's opinion on this point.

What about the red color, is there a red that does not shine as much to accompany the darker green?
Red is now this color.


Here is a sample of colors that can be set in the GUI.
Corresponds to lightening when not pressing the button.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #39 on: January 29, 2019, 10:07:58 PM »
I do like this - this does make things rather clearer. One small thing: I think that I prefer the green check not in the circle to the one with the circle.

Other than that, is this ready for final testing and possibly implementation so far as you are concerned?

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #40 on: January 30, 2019, 11:00:27 AM »
Other than that, is this ready for final testing and possibly implementation so far as you are concerned?
Yes. One thing that I care about is the label text of "Happy" is OK? But this can be edited easily using the translation function.

I think that I prefer the green check not in the circle to the one with the circle.
I replaced the image. Before you test you need to make a pak file.
The source file is here.
https://github.com/Ranran-the-JuicyPork/simutrans-pak128.britain/tree/master/gui/gui64

I attach the dat file of the translated word to be added.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #41 on: January 31, 2019, 11:31:36 PM »
I do not have time to test this evening, but it is an interesting question whether the word "happy" should be changed either in the base texts or the translations. I suspect that it may be better to change it in the translations so as not to interfere with existing translations, but I wonder whether "Pass. transported" might be better?

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #42 on: February 02, 2019, 04:26:52 PM »
Thank you very much for your work on this: I am testing this now and it does look good. One very small thing: the text for "No route (pass.)" and "No route (mail)" in the buttons for the chart seems a few pixels higher than the other text for the buttons. Do you think that you could adjust this?

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #43 on: February 02, 2019, 06:05:09 PM »
the text for "No route (pass.)" and "No route (mail)" in the buttons for the chart seems a few pixels higher than the other text for the buttons. Do you think that you could adjust this?
Hmm, I do not think that only the text of those buttons is different position...
I thought whether it is on above because of lowercase "g", "q", "p" and "y", but it looks a little bit higher in Japanese too.

Then , why don't you lower it by 1px when the button is pressed like this?

https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/4570bbe3bedf47b9d1106b6f2123361d321de42f

EDIT:
It may be due to the difference in button color and frame color that it looks higher position. (red vs blue)

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #44 on: February 03, 2019, 12:50:09 PM »
Thank you very much for this. Looking very carefully at the buttons, it seems as though all the text might be slightly high, although I am not sure why; however, I do like your idea (and implementation) of lowering the text when the button is pressed.

In any event, I have now incorporated this, as any further issues that there might be are very minor. Therefore, the game with this new feature will be available from to-morrow's nightly build.

Thank you very much for your work on this - it is much appreciated.

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #45 on: February 03, 2019, 05:37:51 PM »
Thank you for testing and incorporating and many feedbacks.
I hope you guys like it. ;)

Offline wlindley us

  • Devotee
  • *
  • Posts: 970
    • Hacking for fun and profit since 1977
  • Languages: EN, DE
Re: Passengers evaluation icon on station information window
« Reply #46 on: February 03, 2019, 11:35:09 PM »
On Linux Mint 18.1 with g++ 5.4.0, current git build results in fatal compile error:

Code: [Select]
gui/halt_info.cc: In member function ‘virtual void halt_info_t::draw(scr_coord, scr_size)’:
gui/halt_info.cc:532:48: error: ‘round’ is not a member of ‘std’
     int mail_delivered_percentage = mail_sum ? std::round((double)(halt->haltes
                                                ^

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #47 on: February 04, 2019, 12:48:23 AM »
W. Lindley - is this an error that you can confirm relates specifically to these changes?

Offline Phystam jp

  • *
  • Posts: 228
  • Pak256.Ex developer
  • Languages: JP, EN, EO
Re: Passengers evaluation icon on station information window
« Reply #48 on: February 04, 2019, 05:33:46 AM »
I could reproduce the error while compiling with mingw64 g++ compiler.

std::round is introduced from c++11. So you have to set the build option -std=c++11 or use other function.

Offline Ranran jp

  • *
  • Posts: 471
  • Languages: ja
Re: Passengers evaluation icon on station information window
« Reply #49 on: February 04, 2019, 08:48:26 AM »
Thank you for pointing it out and I apologize the inconvenience I have caused. (´・ω・`)
I threw a pull request for fixing this.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #50 on: February 04, 2019, 11:02:21 AM »
Interesting. I am in the process of incorporating Ranran's fix, but I should note that C++11 is, I believe, the standard now for Simutrans (and Simutrans-Extended) code; the thread_local keyword is used in Simutrans-Extended, for example, and this is part of the C++11 specification.

Offline Phystam jp

  • *
  • Posts: 228
  • Pak256.Ex developer
  • Languages: JP, EN, EO
Re: Passengers evaluation icon on station information window
« Reply #51 on: February 04, 2019, 01:58:29 PM »
Maybe there is missing header file in gui/halt_info.cc.
When I added
Code: [Select]
#include <cmath>
then I could compile it.

--EDIT--
It also worked well on pak256-Ex! Looks good!


--EDIT2--
I modified the icons for pak256-Ex. However I cannot change the color of evaluation bars...
« Last Edit: February 04, 2019, 04:46:15 PM by Phystam »

Offline thegamer7893 england

  • *
  • Posts: 787
  • Languages: EN
[Q] Passengers evaluation icon on station information window
« Reply #52 on: February 10, 2019, 04:32:30 PM »
When will this all be incorporated into the main game?

I feel like I'm asking the same question again but, when will all of these excellent touches to the in-game station information window be added? (mainly directed at James) Although, all of this does look certi (good/excellent in UK slang)

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18690
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Passengers evaluation icon on station information window
« Reply #53 on: February 10, 2019, 04:42:33 PM »
As stated in this post on this very thread, these changes have already been incorporated.

Offline thegamer7893 england

  • *
  • Posts: 787
  • Languages: EN
[Thumb up] Passengers evaluation icon on station information window
« Reply #54 on: February 11, 2019, 04:40:39 PM »
I never saw that post, sorry. But, I must say that it is a really noice feature