News:

SimuTranslator
Make Simutrans speak your language.

[Solved] Mouseover this Tram piece in the depot crashes game.

Started by JasoSSTO, March 23, 2019, 12:26:38 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

JasoSSTO

Using the latest Nighty Build, Extended, Pak128-BritainEX. Both 32 and 64 Windows versions.

It's not savegame specific as it always happens no matter the date or the savegame.
I also tried a clean no-changes fresh version downloaded today and the crash also happens without changing a single option.
It only happens with the Siemens-Duewag Supertram rear piece. No other piece of the same tram or any other tram causes the crash.
I am able to buy and run the whole tram since clicking on the front piece also buys the rest of the tram.
It crashes both mouseovering the piece for selection and when it's in the top, already bought. The crash is immediate and no info appears about the piece in the depot.
When the tram is outside the Depot it causes no issues.

Savegame where I tested this https://simutrans-germany.com/files/upload/TramCrashTest.sve

If any other info is needed please tell me.

jamespetts

May I ask what pakset that you are using with this? This does not seem to be loadable with Pak128.Britian-Ex.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

JasoSSTO

Oh, I'm sorry, I saved using a modified version of Pak128BritEx so that's probably why you couldn't open.
I've downloaded a clean install and made a test save there, nothing is modified. The only thing that I've changed is the setting to allow buying out of production vehicles so that the tram could be bought in 2010, the year I tested this. Unfortunately the crash still happens in this install.
https://simutrans-germany.com/files/upload/TramCleanTest.sve

Hope this helps.

Ranran(retired)

I apologize for the inconvenience.
This is the effect of my tab patch. (´・ω・`)

There is no description of engine_type in dat file even though the 3rd (rear) car of this tram has power.
https://github.com/jamespetts/simutrans-pak128.britain/blob/master/trams/sheffield-supertram-rear.dat
This should be set to engine_type=electric.

It used to treat it as diesel, but it is now recognized as unknown.

EDIT:
These also contain the same kind of error.
https://github.com/jamespetts/simutrans-pak128.britain/blob/master/trains/br-442.dat
https://github.com/jamespetts/simutrans-pak128.britain/blob/master/trains/br-120.dat
https://github.com/jamespetts/simutrans-pak128.britain/blob/master/trams/sheffield-vossloh-tramtrain.dat
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Thank you both for that. I am afraid that I cannot reproduce the crash. However, I have fixed the omissions in the pakset as identified by Ranran. JasoSSTO - I should be grateful if you could re-test with to-morrow's pakset build to confirm whether this fixes the problem for you.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Quote from: jamespetts on March 25, 2019, 08:48:38 PMI am afraid that I cannot reproduce the crash.
The crash was only seen in release builds and could not be reproduced in debug builds.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

JasoSSTO

Yes, the crash has been solved, now mouseovering the piece works as intended. Thank you Ranran and James for the help.   ;D

I've noticed the piece now appears under "electric units" instead of under "passenger carriages". I'm guessing that was one of the issues.
I haven't checked the other pieces as I don't know which ones they are, though I imagine they also shouldn't crash the game.