News:

The Forum Rules and Guidelines
Our forum has Rules and Guidelines. Please, be kind and read them ;).

[Bug fix] Station mail records are not written in the save data

Started by Ranran(retired), April 19, 2019, 09:07:21 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

I noticed that every time I reloaded the saved game then the station's mail record was lost.  ???
This is due to an error in my code when Ranran implemented this. (´・ω・`)

I made a patch for fix this.
https://github.com/Ranran-the-JuicyPork/simutrans-extended/commits/bug-fix-of-station-mail-record

I apologize for the inconvenience, but please check this.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

I'm very sorry, the patch seems to have caused problems loading the old save.
It is not possible to load the save generated by the build after 2019/02/05. (You can load the today's build saved game.)


if ((file->get_extended_version() == 14 && file->get_extended_revision() > 5) || file->get_extended_version() > 15)

If you edit line 3973 of simhalt.cc like this, it will be able to load the saved game of 2019/02/05 - 2019/04/06's build.
However, I have no idea why it can not read the saved game after 04/07's build (ie get_extended_revision () == 8, with modified path_exploler).
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

Jando

I'm seeing the latest nightly crash on loading any of my saved games. This is the Linux 64-bit version. Game either crashes directly to desktop or shows the following error message:



Bug or user error? :)

jamespetts

These two issues appear to be the same - I am looking into this now.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

jamespetts

I think that I have now fixed this. I am about to run a manual recompile of the nightly build with this fix integrated.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

All saved game from February to April can now be loaded.  :D
Thank you very much!
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

Jando

Confirming issue fixed for me as well, thank your for the fast response!