News:

Simutrans Tools
Know our tools that can help you to create add-ons, install and customize Simutrans.

Tutorial - code review

Started by Andarix, May 15, 2025, 01:22:00 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Andarix

https://github.com/simutrans/tutorial_multipak/commit/b338cc55bdfe861957a99e6b3e35a6e850b9c89b

reupload

I had actually corrected it and re-uploaded it. Apparently, however, the file wasn't updated in the archive.

Yona-TYT

Excellent work! The tool and menu icons look great; implementing this was a good idea.  8)
 simscr00.png

prissi

Some testing (in English):
1) before building depot: When building a road (by pressing 's' in pak64), I cannot proceed as I cannot build anything. Only by selecting from the toolbar I can proceed. (Contrary to the text, any road seems to work, even the 40 km/h gavel road.)
2) The line step does not mention (in English) that one can copy the convoi. Also it is unclear in which window the new line is to be created.
3) Heap buffer overflow (with address sanitizer) when selecting the last stop in the schedule for the connenction. Error originat from a call from is too allowed 4108 with param = "D\td\x1\x1\x4セセ@Kr\x5\b\x5セセ\x2\x3" I guess so output is generated from this function which is forbidden. Same if jumoping to this step and click on the bus and then on its schedule.