News:

SimuTranslator
Make Simutrans speak your language.

The color of the top border of the banner is fixed

Started by Ranran(retired), March 01, 2021, 02:39:32 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

The color of the top border of the banner is fixed in light gray(RGB=222,218,222).

This part is this color(RGB=222,218,222) in all themes. This is incorrect for all themes, but it's not very noticeable at the moment.
However, it becomes noticeable with the following theme settings.



I suspect it may be because this window doesn't have a title bar.
Basically, I only report bugs occasionally, never provide patches for new features.
I may only work on fixing bugs that are caused by Ranran.
Fork of simutrans extended for Jalápagos is here.

Ranran(retired)

// add white line on top since this frame has no title bar.
display_fillbox_wh_clip_rgb(pos.x, pos.y, size.w, 1, color_idx_to_rgb(COL_GREY6), false);

This behavior seems to be intended. But I don't think this behavior is correct.
Basically, I only report bugs occasionally, never provide patches for new features.
I may only work on fixing bugs that are caused by Ranran.
Fork of simutrans extended for Jalápagos is here.

Dwachs

Parsley, sage, rosemary, and maggikraut.

Ranran(retired)

Quoteshould be fixed in r9673
I find that this bug was still unresolved. (´・ω・`)
I think you made something that should be displayed, but I don't think the display will change because you haven't removed the COL_GREY6 upper frame that was used as a countermeasure before the fix.
Need to remove the lines already mentioned.
Basically, I only report bugs occasionally, never provide patches for new features.
I may only work on fixing bugs that are caused by Ranran.
Fork of simutrans extended for Jalápagos is here.

Dwachs

Which theme setting controls that green color? Just to be sure. Years back I received quite a beating because of the (then missing) line.
Parsley, sage, rosemary, and maggikraut.

Ranran(retired)

Quote from: Dwachs on November 05, 2021, 09:32:51 AMWhich theme setting controls that green color? Just to be sure. Years back I received quite a beating because of the (then missing) line.
I don't remember the details, but I think the frames are all images included in the pak.
Please test it by using the attached theme.
Basically, I only report bugs occasionally, never provide patches for new features.
I may only work on fixing bugs that are caused by Ranran.
Fork of simutrans extended for Jalápagos is here.

Dwachs

Parsley, sage, rosemary, and maggikraut.