r10996 - nettool not compile all OS

[Andarix]

linux

2023-10-29T04:48:16.3962988Z nettool.cc:63:64: error: too many arguments to function 'network_command_t* network_check_activity(int)'
2023-10-29T04:48:16.3967661Z    63 |   network_command_t* nwc = network_check_activity( NULL, 10000 );
2023-10-29T04:48:16.3968799Z       |                                                                ^
2023-10-29T04:48:16.3969967Z In file included from nettool.cc:20:
2023-10-29T04:48:16.3971079Z ../simutrans/network/network.h:101:20: note: declared here
2023-10-29T04:48:16.3972189Z   101 | network_command_t* network_check_activity(int timeout);
2023-10-29T04:48:16.3972940Z       |                    ^~~~~~~~~~~~~~~~~~~~~~
2023-10-29T04:48:16.4348216Z nettool.cc: In function 'bool fill_nwc_service(nwc_service_t&, uint32, int, char**)':
2023-10-29T04:48:16.4351212Z nettool.cc:102:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
2023-10-29T04:48:16.4412973Z   102 |    if (argv[1]) {
2023-10-29T04:48:16.4413476Z       |    ^~
2023-10-29T04:48:16.4413959Z nettool.cc:106:3: note: here
2023-10-29T04:48:16.4415669Z   106 |   case 1: // first argument is a positive number
2023-10-29T04:48:16.4416293Z       |   ^~~~
2023-10-29T04:48:16.4417154Z nettool.cc: In function 'int lock_company(SOCKET, uint32, int, char**)':
2023-10-29T04:48:16.4418808Z nettool.cc:355:9: warning: ignoring return value of 'int scanf(const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
2023-10-29T04:48:16.4420255Z   355 |    scanf("%255s", password_in);
2023-10-29T04:48:16.4420764Z       |    ~~~~~^~~~~~~~~~~~~~~~~~~~~~
2023-10-29T04:48:16.4422158Z nettool.cc:364:9: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result [-Wunused-result]
2023-10-29T04:48:16.4423435Z   364 |    fgets(password_in, size, fd);
2023-10-29T04:48:16.4424164Z       |    ~~~~~^~~~~~~~~~~~~~~~~~~~~~~
2023-10-29T04:48:16.4425018Z nettool.cc: In function 'int main(int, char**)':
2023-10-29T04:48:16.4426672Z nettool.cc:503:11: warning: ignoring return value of 'char* fgets(char*, int, FILE*)', declared with attribute warn_unused_result [-Wunused-result]
2023-10-29T04:48:16.4428031Z   503 |      fgets(password, size, fd);
2023-10-29T04:48:16.4428579Z       |      ~~~~~^~~~~~~~~~~~~~~~~~~~
2023-10-29T04:48:16.4430047Z nettool.cc:589:8: warning: ignoring return value of 'int scanf(const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
2023-10-29T04:48:16.4431367Z   589 |   scanf("%255s", password);
2023-10-29T04:48:16.4431881Z       |   ~~~~~^~~~~~~~~~~~~~~~~~~
2023-10-29T04:48:16.4441162Z make: *** [../../uncommon.mk:63: ../../build/default/nettool/nettool-nettool.o] Error 1
2023-10-29T04:48:16.4454141Z ##[error]Process completed with exit code 2.

windows

2023-10-29T04:49:06.9625682Z   nettool.cc
2023-10-29T04:49:21.0470472Z D:\a\simutrans\simutrans\src\nettool\nettool.cc(63,64): error C2660: 'network_check_activity': function does not take 2 arguments [D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj]
2023-10-29T04:49:21.0473538Z D:\a\simutrans\simutrans\src\simutrans\network\network.h(101,20): message : see declaration of 'network_check_activity' [D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj]
2023-10-29T04:49:22.2959877Z   simdebug.cc
2023-10-29T04:49:22.5721989Z   simmem.cc
2023-10-29T04:49:22.8610866Z   freelist.cc
2023-10-29T04:49:23.0148751Z   memory_rw.cc
2023-10-29T04:49:23.3292074Z D:\a\simutrans\simutrans\src\simutrans\network\memory_rw.cc(134,26): warning C4267: '=': conversion from 'size_t' to 'uint16', possible loss of data [D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj]
2023-10-29T04:49:23.3684802Z   network.cc
2023-10-29T04:49:24.1461305Z   network_address.cc
2023-10-29T04:49:24.8648901Z   network_cmd.cc
2023-10-29T04:49:25.5567379Z   network_file_transfer.cc
2023-10-29T04:49:26.2727691Z   network_packet.cc
2023-10-29T04:49:26.9516466Z   network_socket_list.cc
2023-10-29T04:49:27.7850432Z   fetchopt.cc
2023-10-29T04:49:27.8499428Z   log.cc
2023-10-29T04:49:28.1256718Z   sha1.cc
2023-10-29T04:49:28.4652631Z   sha1_hash.cc
2023-10-29T04:49:28.6514071Z   simstring.cc
2023-10-29T04:49:33.3239938Z Done Building Project "D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj" (default targets) -- FAILED.
2023-10-29T04:49:33.6590487Z
2023-10-29T04:49:33.6591289Z Build FAILED.
2023-10-29T04:49:33.7178970Z
2023-10-29T04:49:33.7181015Z "D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj" (default target) (1) ->
2023-10-29T04:49:33.7182639Z (ClCompile target) ->
2023-10-29T04:49:33.7184981Z   D:\a\simutrans\simutrans\src\simutrans\network\memory_rw.cc(134,26): warning C4267: '=': conversion from 'size_t' to 'uint16', possible loss of data [D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj]
2023-10-29T04:49:33.7186694Z
2023-10-29T04:49:33.7186834Z
2023-10-29T04:49:33.7187471Z "D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj" (default target) (1) ->
2023-10-29T04:49:33.7188509Z (ClCompile target) ->
2023-10-29T04:49:33.7190693Z   D:\a\simutrans\simutrans\src\nettool\nettool.cc(63,64): error C2660: 'network_check_activity': function does not take 2 arguments [D:\a\simutrans\simutrans\src\nettool\Nettool.vcxproj]
2023-10-29T04:49:33.7192326Z
2023-10-29T04:49:33.7192561Z     1 Warning(s)
2023-10-29T04:49:33.7193050Z     1 Error(s)
2023-10-29T04:49:33.7726601Z
2023-10-29T04:49:33.7727525Z Time Elapsed 00:00:49.11
2023-10-29T04:49:34.8302113Z ##[error]Process completed with exit code 1.

[ceeac]

This has already been fixed in r10998.

[Andarix]

works

thans