News:

Use the "Forum Search"
It may help you to find anything in the forum ;).

124.2.2 pak128 - built tunnel

Started by Andarix, November 20, 2024, 08:44:41 AM

Previous topic - Next topic

0 Members and 2 Guests are viewing this topic.

Andarix

If you build a tunnel and then remove it again, the track remains on the slope field. This is contradictory because you cannot build on the steep slope.

Another problem is that with the converted tutorial map from pak64 the track does not connect to the tunnel. However, with a new pak128 card it works.

[EDIT]
Hmm, if I load the tutorial map directly, then the connection between the tunnel and the track works.

It doesn't work in the scenario.

Yona-TYT

Quote from: Andarix on November 20, 2024, 08:44:41 AMIf you build a tunnel and then remove it again, the track remains on the slope field. This is contradictory because you cannot build on the steep slope.

Another problem is that with the converted tutorial map from pak64 the track does not connect to the tunnel. However, with a new pak128 card it works.

[EDIT]
Hmm, if I load the tutorial map directly, then the connection between the tunnel and the track works.

It doesn't work in the scenario.
Please submit your script and a savegame for testing here.

Andarix

#2
Quote from: Yona-TYT on November 20, 2024, 04:00:48 PMPlease submit your script and a savegame for testing here.

Yona-TYT


Ok, I can solve that by adjusting:

bord3_lim.b = coord(96,172)
c_tway_lim2.a = coord(95,172)
Captura de pantalla -2024-11-20 21-22-11.pngCaptura de pantalla -2024-11-20 21-22-32.pngCaptura de pantalla -2024-11-20 21-22-54.png

Andarix

Quote from: Yona-TYT on November 21, 2024, 01:16:20 AMOk, I can solve that by adjusting:

bord3_lim.b = coord(96,172)
c_tway_lim2.a = coord(95,172)
...

Changing c_tway_lim2.a is enough.

Yona-TYT

Quote from: Andarix on November 21, 2024, 08:13:57 AMChanging c_tway_lim2.a is enough.
Yes I know, I just wanted the "X" limits to be more adjusted, but if there are no problems then it's fine.  ;)

Andarix

I have the same problem with the passenger tunnel. The tunnel is not connected to the bridge.

Screenshot 2024-11-21 233404.jpg

Yona-TYT

Quote from: Andarix on November 21, 2024, 10:37:50 PMI have the same problem with the passenger tunnel. The tunnel is not connected to the bridge.
Screenshot 2024-11-21 233404.jpg
This time I tried without the script and the result is the same, could it be a bug?.

Edit.
Interestingly if you build the tunnel first and then the bridge then they do connect.

Captura de pantalla -2024-11-21 18-46-27.png

Andarix

It is a general problem because in tunnels, unlike bridges, the connecting field is not built with a way.

Andarix

I have found a solution for the tutorial.

However, the check does not work properly when continuing to build the tunnel.

Screenshot 2024-11-22 170531.jpg

Automatic construction has not yet been tested. The tunnel was not connected to the bridge there either.

There is also no reference to the missing Ctrl key when building the tunnel portal.

Yona-TYT

#10
I think it would be more convenient to edit the map and move the river a couple of tiles so that the bridge is not right at the entrance of the tunnel, I can do that.

Edit.
Quote from: Andarix on November 22, 2024, 04:08:02 PMThere is also no reference to the missing Ctrl key when building the tunnel portal.
This is pending, but we will have to change it to the last night of simutrans, do you agree?.

Quote from: Andarix on November 22, 2024, 04:08:02 PMHowever, the check does not work properly when continuing to build the tunnel.

I'm going to check.

Ok, fix.

For pak128 dir_1.s = 56:   
dir_1 = {s = 56, r = 2 }    //Direccion de la slope y Way ribi

Andarix

Quote from: Yona-TYT on November 22, 2024, 04:56:00 PMI think it would be more convenient to edit the map and move the river a couple of tiles so that the bridge is not right at the entrance of the tunnel, I can do that.

...


Since this is a problem in Simutrans itself, I think it will be fixed at some point. Then the extra code can be removed again.

I think the PR is now complete and works. Although the active tools still need to be checked again.

Text adjustments are still missing.

Yona-TYT

I think we should build on last night's release, there are new parameters that will be incorporated in the next release.

Yona-TYT

#13
Quote from: Andarix on November 22, 2024, 07:13:39 PMAlthough the active tools still need to be checked again.
Are you referring to the slope tools? I noticed that for some reason they don't appear, so I had to modify "class_basic_gui" in order to move forward.

Edit.
Quote from: Andarix on November 22, 2024, 07:13:39 PMSince this is a problem in Simutrans itself, I think it will be fixed at some point.
Well, if I remember correctly, important changes were made to that code a few months ago, but I think it's the kind of thing that gives @prissi gray hair. :o

prissi

#14
Must be a problem with double slopes, as pak64 always connects to the tunnel. I will investigate it.

EDIT: should be fixed after r11437

Yona-TYT

Quote from: prissi on November 24, 2024, 12:48:12 PMMust be a problem with double slopes, as pak64 always connects to the tunnel. I will investigate it.

EDIT: should be fixed after r11437
I have tried last night, but it seems that there are still connection problems.
Captura de pantalla -2024-12-18 09-33-53.png

prissi

Can I have a savegame. It works for me in my tests.

Andarix

#17
https://github.com/simutrans/tutorial_pak64

tutorial128.sve

After the store, the spot is a little further to the left.

After the fix r11437 it worked for me. Actual not tested.

prissi

That seems to work too. However, the tutorial in pak128 is very different from this tutorial. As a new release is imminent, I wonder which tutorial should go with pak128 (and if pak64 tutorial has been fixed).

Andarix

I have rewritten the tutorial for pak64 so that the same code now works for 3 packsets (pak64, pak64.german and pak128). I have converted the map accordingly.

The reason is that there is now about a 10% difference and 90% of the same code is used. This also applies to the translations, which now do not have to be done multiple times.

What is still missing are the different texts for tunnels and bridges for pak128.


This error does not occur in the 64 tutorial.
For the 128 tutorial, an additional check is built into the script code. This is why it works as a tutorial as long as the code is active.



r11487 works with normal building.

Therefore, I assume that it is limitations in the tutorial that are causing the error now. Just like it was with the tunnel before.

Yona-TYT

Quote from: Andarix on December 21, 2024, 02:17:22 PM

r11487 works with normal building.
Therefore, I assume that it is limitations in the tutorial that are causing the error now. Just like it was with the tunnel before.

Oh, sorry, I didn't notice that bug,

It's already fixed here: https://github.com/simutrans/tutorial_pak64/commit/8c53e6176d8c4435b7eb35b5117126763fc43202