r11737: Cursors always use the first player color

[Nazalassa]

When a tool is selected, its cursor is drawn on the map. If the cursor has player color on it, we would expect it to be of the right player color. However, it is not.

Steps to reproduce:

• Open a world, switch to a non-default player with a player color much different than that of the first player (i.e human player).
• Select a tool which cursor has player color on it (e.g marker tool) and observe the cursor.

Expected results:
The player color parts on the cursor should be of the active player's player color.

Observed results:
The player color parts on the cursor are always of the first player's color (i.e human player).

Attached is a patch that fixes this by setting the cursor's owner when the active player changes. (Previously the cursor was ownerless.)


P.S: is it correct to submit a bug report here when I have a patch, or should I rather put it in another subforum (e.g Patches & Projects)?

[ceeac]

Thanks, incorporated in r11744.

P.S: is it correct to submit a bug report here when I have a patch, or should I rather put it in another subforum (e.g Patches & Projects)?

IMO if there is a patch, it is better to post directly in Patches so the patch does not get lost, but for small one-line patches like this one it does not matter much, I guess.