The "Replace Stop" function seems to make convoys line-less

[DThunder518]

I've always liked using the "replace stop" function to help in changing station layouts, etc. This is great in a large station where a lot of lines may use the same stop, and now I need to move it by a tile or two. Using 11993 (in Linux), I've noticed that now when I use that function, it updates any lines that had that stop as expected, however convoys that were assigned to those lines still keep their old schedule and now become line-less. This is especially problematic when that old schedule now has an invalid stop in it because the station was changed/removed/etc and suddenly a lot of convoys can't find a route.

[prissi]

I guess you refer to the move stop tool?

[victor_18993]

I investigated this on current trunk.

The report is valid for r11993, but this particular issue has already been fixed in r12024.

The relevant change is:

    r12024 — FIX: (Nazalassa) updatel line's convois if stop position changed

The Move/Replace Stop tool was already updating the line schedule itself, but it was not calling the normal line-management update path afterwards.

The missing call was:

    player->simlinemgmt.update_line(line);

I also verified this causally by testing current trunk with that single call removed.

Without it, the line schedule is updated but the convoys keep the old stop indefinitely. If the old stop is then removed, the affected convoys can end up with no route.

With current trunk, the convoys are synchronized with the updated line and continue routing normally.

The apparent "line-less" behaviour is a secondary effect: moving the stop itself does not remove the convoy from its line. If a convoy still has the stale schedule and that schedule is later applied manually, it no longer matches the line schedule and the normal schedule logic can detach it from the line.

So this report does not require a new patch on current trunk.

If possible, please try again with a current nightly/revision newer than r12024 and let us know if you can still reproduce it.

[DThunder518]

Thank you Victor_18993, I just tried it with 12024 and it works again. Hooray!

[victor_18993]

¡Genial, gracias por confirmarlo!
Great, thanks for confirming it.
 Then we can consider this issue fixed since r12024. Glad to hear it is working again!