The International Simutrans Forum

 

Author Topic: [bug r2783] Covoi doesn't keep loading when changed schedule  (Read 2447 times)

0 Members and 1 Guest are viewing this topic.

Offline z9999+

  • Coder/patcher
  • *
  • Posts: 377
[bug r2783] Covoi doesn't keep loading when changed schedule
« on: October 17, 2009, 06:28:44 AM »
I don't know why, but all things what I had implemented are broken.
They don't keep loading and go to next stop.

[EDIT]
Ok, I found some problems in check_pending_updates().
It doesn't work well, if I change from 2 entry to 3 entry.
If a line has A-B, and insert C before A, convoi will go to different stop.

But it is Okay, I don't want to break all, so I will continue to discuss after next stable release.
« Last Edit: October 17, 2009, 07:41:08 AM by z9999+ »

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9431
  • Languages: De,EN,JP
Re: [bug r2783] Covoi doesn't keep loading when changed schedule
« Reply #1 on: October 17, 2009, 11:24:17 AM »
If something is inserted in the schedule, then the aktuell position is not the same any more. I.e. the first is_same fails. However, it finds the second position (i.e. the new halt) as matching one, and all is good again. All also for the other positions. In my tests with two stops I could not provoke skipping of a stop.


Offline z9999+

  • Coder/patcher
  • *
  • Posts: 377
Re: [bug r2783] Covoi doesn't keep loading when changed schedule
« Reply #2 on: October 17, 2009, 11:38:14 AM »
Line A-B.
Next stop is B.
Insert C before A, C-A-B

First C gets 6 points and aktuell to A.
Second A will gets 1 points.
Third B will gets 3 points.
Finally convoi go to A.

[EDIT]
But please don't change code before release.
If you changed something, it may cause different problem.
There is no time left to test new one.
« Last Edit: October 17, 2009, 11:47:37 AM by z9999+ »

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9431
  • Languages: De,EN,JP
Re: [bug r2783] Covoi doesn't keep loading when changed schedule
« Reply #3 on: October 17, 2009, 12:03:44 PM »
I tried this single step in debugger and it was fine for a convoi waiting at a stop. A got the most points. But I agree about not changing.