News:

Simutrans Wiki Manual
The official on-line manual for Simutrans. Read and contribute.

[9.x bug] haltestelle_t::waiting_times clean-up.

Started by inkelyad, November 11, 2010, 07:12:02 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

inkelyad

There is none.

in add_waiting_time we do
waiting_times[category].put(halt->get_basis_pos(), ....)
But when halt is deleted, its basis_pos is still here.

Edit:
Should be fixed in my waiting_times_fix branch.

inkelyad


jamespetts

#2
Is this patch intended to address the issue reported in this thread?

Edit: It seems that it is indeed intended to be such a fix, looking at the code. But it looks as if it might be too aggressive a fix: it appends a waiting time of 9 minutes to the end of the fixed-sized list of 16 of the last waiting times every 256 steps, which is every real life minute or so per stop running at normal speed. Also, this will have adverse effects if the actual average waiting time of a stop is below nine minutes: there is no reason in that case to increase average waiting times.

Edit 2: A revised version of this has now been pushed to the 9.x branch - I'd be grateful for any testing.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.