[bug] - Passengers do not take the bus

[Milko]

Hello

Exp 10.2 - Pak64Exp 0.1

I have a strange problem, I attach a save game http://simutrans-germany.com/files/upload/Gioco64_Bug.sve.

Look at Milano sud Porto.
There are 4 buses, all buses are in the same circular line (two are in one direction, the other two are in the opposite direction). None of the four bus loads passengers waiting for a station in Milan.
Buses remain on hold and leave almost empty. Passengers waiting, however, there are over a hundred.

Edit: The problem is not visible from the savegame that I enclose, as soon as you load all the buses fill up miraculously. Over time, however, becomes visible. It seems that when more than one bus of the same line and with the same direction is waiting, the game may not be able to choose which bus load.

Giuseppe

[greenling]

Milko
Hate the station a allow form passenger?

[jamespetts]

Hmm - odd. I can reproduce this, but the cause is not currently clear to me. I know that the simultaneous loading thing was modified by Inkelyad, so I have not looked at that part of the code in detail. I am not sure whether this is responsible, however. I also know that I have fixed some bugs with circular routes and the point to point journey times in the latest work on Github (not the 10.x branch - the revenue-sharing branch), which conceivably might have been responsible, but testing with the latest branch has the same effect, so this is probably not the issue.

If anyone has any ideas as to what might cause this, I should be most grateful.

Edit: This problem only occurs when more than one convoy serving the same line is waiting at the stop at the same time. I am looking into void haltestelle_t::update_alternative_seats(convoihandle_t cnv).

Edit: I think that I have fixed the problem on the 10.x branch - it was a fairly obscure bug relating to the code for overcrowding, which only occurred when more than one convoy each containing only one vehicle was waiting at the same halt on the same line at the same time. Thank you for the report!

[Milko]

Hello

The bug is fixed.

Thank you for the report!

Thank you James  


The link contain a "nightly" (10.x repository, update oct 26) containing all recent bugfix **, it is not an official release and is only windows version.
http://simutrans-germany.com/files/upload/Exp_103_2610.zip

Bugfix:
** Long distance revenue and average speed
** [bug] - Passengers do not take the bus
** Vector out of bounds

Giuseppe