I think the splash screen is missing a bright line

[Spike]

I think the game's splash screen is missing a bright line on top. At least my memory wants to tell me that former releases had one there. (I mean a line about as bright as the left border line).

[Spike]

This problem is still present in 111.1

[Markohs]

Can any developer have a look over this critical bug please?

[Spike]

Can any developer have a look over this critical bug please?

Thanks for the support. It's not critical in terms of usability or playability, but if we want to make Simutrans more popular, it's important to leave a good first impression and the splash screen is the thing that a new player will see right after starting the program. So IMO it is essential to make it as good looking as one can.

[Markohs]

Excuse me, it was just some ironic comment I found funny when I wrote it because I had just taken a pint of beer, don't take it personal please.

Of course it's good trying to make simutrans looking better.

But I can try to have it a look, when did the change happen approximately?

EDIT: nvm, I found a solution:

gui/gui_frame.cc, line 169:

Code Select Expand


    // Hajo: left, right
    display_vline_wh(pos.x, pos.y+16, gr.y-16, MN_GREY4, false);
    display_vline_wh(pos.x+gr.x-1, pos.y+16, gr.y-16, MN_GREY0, false);

    // Hajo: bottom line
    display_fillbox_wh(pos.x, pos.y+gr.y-1, gr.x, 1, MN_GREY0, false);


Should be:

Code Select Expand


    // Hajo: left, right
     display_vline_wh(pos.x, pos.y+16, gr.y-16, MN_GREY4, false);
     display_vline_wh(pos.x+gr.x-1, pos.y+16, gr.y-16, MN_GREY0, false);

     // Hajo: top, bottom
     display_fillbox_wh(pos.x, pos.y+16, gr.x, 1, MN_GREY4, false);
     display_fillbox_wh(pos.x, pos.y+gr.y-1, gr.x, 1, MN_GREY0, false);


Even I *think* I have access to modify the simutrans trunk code, noone gave me explicit permission to do it. So please, can someone make this change in trunk?

[Dwachs]

Is there any reason to change this?
There is also a config setting to get complete window borders for active window (which also apply to the window in question):

Code Select Expand


# first: draw a frame with titlebar color around active window
#window_frame_active = 0

The available history (going back to 0.84.20) imho does not show that there has been a bright lines at top/left as topic opener assumes

[Spike]

My memory ain't perfect all the time. The trigger was that I felt this line missing when I made the skin for pak48.Excentrique and some people whom I had shown the screenshot also agreed that a bright line would look good there.

Thank you for adding it!

I didn't know about the config option. Might have been done by one of my helpers, I don't remeber coding that. I believe in the shown code piece that says I left this line out, because I tried to optimize all drawing operations by keeping them as minimal as possible and the line was most likely not needed with the old skins.

[Markohs]

The top white line makes the window look better, I'd personally prefer it with the line that with a titlebar, but that's just my opininon.

[Spike]

Patch:

Code Select Expand


Index: banner.cc
===================================================================
--- banner.cc   (revision 5180)
+++ banner.cc   (working copy)
@@ -125,6 +130,9 @@
#include "../scrolltext.h"
        };

+       // Hajo: add while line on top since this frame has no title bar.
+       display_fillbox_wh(pos.x, pos.y + 16, gr.x, 1, COL_GREY6, false);
+
        const KOORD_VAL text_line = (line / 9) * 2;
        const KOORD_VAL text_offset = line % 9;
        const KOORD_VAL left = pos.x+10;