r5424: cannot save

[whoami]

On r5424 (so this might apply to V111.2!) Win-XP SDL (pak64 default map; pak.german developed map), I cannot save at all. Error message is "Kann Spielstand nicht speichern".
The log says only this:
Message: karte_t::speichern():    saving game to 'save/test.sve'
ERROR: karte_t::speichern():    cannot open file for writing! check permissions!

With r5390, I do not have this problem.

[kierongreen]

Glad it's not only me! Confimed on debian linux svn 5401 introduced this bug.

[kierongreen]

Incidentally a workaround should be to save as binary rather than zipped.

[Dwachs]

setting this to bzip2 works equally well. So it seems, only zip is broken :/

Edit: should be fixed in r5427.

[whoami]

Good - thanks. But this error has existed for one week and seems to have gone into the upcoming release (111.2).

[Dwachs]

Yes thats true :/  It does only effect saving in zipped format, bzip2 format (which should be the default) works.

[kierongreen]

I'm not sure it's default for all paksets. I noticed it Friday but decided to report it as couldn't entirely rule out possibility changes I'd made to code I'd made had caused it...

[prissi]

Anyway, rereleased 111.2 ...

[kierongreen]

Appears to still be bug when saving then reloading game in zipped format:

FATAL ERROR: vector_tpl<T>::[]
PK12baum_besch_t: index out of bounds: -128 not in 0..1

#4  0x08085fe6 in vector_tpl<baum_besch_t const*>::operator[] (this=0x82ee604, i=4294967168)
    at boden/../tpl/vector_tpl.h:229
#5  0x08085845 in boden_t::boden_t (this=0xdbdfe90, welt=0xd7eab38, file=0xbfffcfa0, pos=...) at boden/boden.cc:33
#6  0x081d3273 in planquadrat_t::rdwr (this=0xdb59c14, welt=0xd7eab38, file=0xbfffcfa0, pos=...) at simplan.cc:257
#7  0x0820c3bf in karte_t::laden (this=0xd7eab38, file=0xbfffcfa0) at simworld.cc:4529
#8  0x0820b2d7 in karte_t::laden (this=0xd7eab38, filename=0xbfffd0fc "save/test3.sve") at simworld.cc:4275
#9  0x08130382 in loadsave_frame_t::action (this=0xdaa55b0, filename=0xbfffd0fc "save/test3.sve")
    at gui/loadsave_frame.cc:63

Does not seem to happen in binary format.

[Dwachs]

should be fixed in r5433.

sorry for this release-postponing stupidity :(