The International Simutrans Forum

 

Author Topic: R5729 Win: Hang on growing cities  (Read 1921 times)

0 Members and 1 Guest are viewing this topic.

Offline Carl

  • Devotee
  • *
  • Posts: 1572
    • Website
  • Languages: EN
R5729 Win: Hang on growing cities
« on: May 20, 2012, 11:27:44 AM »
If you place a new city and grow it repeatedly, the game will eventually hang for minutes at a time -- sometimes indefinitely. This usually comes after the city has over 10,000 citizens. The effect may be worse on large maps.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4564
  • Languages: EN, DE, AT
Re: R5729 Win: Hang on growing cities
« Reply #1 on: May 20, 2012, 12:35:22 PM »
Could not reproduce this, it works for me for cities up to 100.000 size. Which pak? Can you upload the savegame / map, where this happens ?

Offline Junna

  • Devotee
  • *
  • Posts: 1081
Re: R5729 Win: Hang on growing cities
« Reply #2 on: May 20, 2012, 04:31:54 PM »
Is this with experimental? For I do remember having this happen to me quite numerous times in experimental, albeit not, to my memory, in standard.

Offline Carl

  • Devotee
  • *
  • Posts: 1572
    • Website
  • Languages: EN
Re: R5729 Win: Hang on growing cities
« Reply #3 on: May 21, 2012, 08:43:25 AM »
I observed this on pak64 and pak128, more often with maps larger than 2000*2000. That might be what's making the difference. I'll test this again tonight to see whether it is exclusively tied to large maps.

Junna -- I was testing in Standard, but it's quite likely that the relevant code is unchanged in Experimental, so also likely that the same bug would show up there.

Offline Carl

  • Devotee
  • *
  • Posts: 1572
    • Website
  • Languages: EN
Re: R5729 Win: Hang on growing cities
« Reply #4 on: May 21, 2012, 05:01:55 PM »
As promised:

On a 1500x1500 map (no cities) in pak128 2.0.0:

-- Place one city, grow it to 50,000, no problem
-- Place second city, grow it to a significant amount = game hangs and appears not to recover.

Perhaps this is related to industry placement or similar (since industries appear as population grows)?

I should note that I'm using an amended menuconf.tab (as suggested by Combuijs here) to make growing the cities 1000 citizens at a time, but I doubt this could be the cause.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9454
  • Languages: De,EN,JP
Re: R5729 Win: Hang on growing cities
« Reply #5 on: May 21, 2012, 09:42:11 PM »
Most of the long interruptions (with pedestrians still moving) are spent in the factory chain constructor. With very large maps, search for palces with factories takes very long (another area for multithreaded code, since this search is read only on plain ground tiles.

The logfile should tell you what was attempted last, i.e. if this is actually the case.

Offline Carl

  • Devotee
  • *
  • Posts: 1572
    • Website
  • Languages: EN
Re: R5729 Win: Hang on growing cities
« Reply #6 on: May 22, 2012, 06:56:33 AM »
Thanks prissi.


So one could presumably avoid this by making the "industry_increase_every" value very high, to curb expansion of industry chains.
« Last Edit: May 22, 2012, 08:37:11 AM by carlbaker »

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9454
  • Languages: De,EN,JP
Re: R5729 Win: Hang on growing cities
« Reply #7 on: May 22, 2012, 06:11:39 PM »
setting it to zero will not expand at all.