The International Simutrans Forum

Development => Bug Reports => Topic started by: HyperSim on September 25, 2017, 06:52:31 AM

Title: [r8293] Load passangers scheduled to go to depot
Post by: HyperSim on September 25, 2017, 06:52:31 AM
Hello, everyone.

When you set line and insert "Depot" in the middle of schedule like this.

(https://lh3.googleusercontent.com/dayaWLTrZni5DA0no7QWfk9SvevbF2R3jglUzopLu7NuUAeOIA2MHZ_ODE034gsN6Bkc6wfWUpMykfLW8Xk4Mcb7SXp65Txv8kRUetqQgfizepBtuU_qz-j4k857mVVrNMZYD9K79mg8lpGK0oR3fQRE0QeP7GjwClpQXs41_dwvH7n34DOjtrtr4heSbbqJYDyfWZMb9thhZZb2jBdIadTIy6SDMEYOUH37C8-GE1mG3CXlcFBpIBxWCv8m9cSnwptdxmKOmhyun1pWOZOCcO6MhpVNUegsUkvVF9sydAeEfsnYYHd4iEif-bfrOc9r8Lqdd5Rf-pt8tau88vTI5q7fdBBmG9xHPhPNlsx2ZLbSqQ_613XcwA2Fl1Wi9WcWcpZHfoDxySR26kIGtxyeqiq6sk2noHxDuRW1UpbtqAuGKXX97EwvBcFawHPKSP31nxyGsF22Gk3snZ-7jeq0Y7v2UqOfh6VTkyhopShXwIhBNzIZwn7aFkdIwMX5eCL3dhbhVIcljwv2wSYFaZoKl8USLdmUDWzYa8g7tE1RVZiReP8XVYH9g5kAF4LgG7UOI1VrtPymDL1kK2s5jNUtLDZF38Cu_WYV2wGQVt_d=w852-h598-no?pageId=109376090069053567400)

Passangers at stop A believe this bus will go to stop B but the bus will go to depot and passangers will disappear.


I saw the source code (r8293) and found this in simconvoy.cc (l.2890).
I think this part does not work well.


if(  grund_t *gr = welt->lookup( schedule->entries[wrap_i].pos )  ) {
if(  gr->get_depot()  ) {
// do not load for stops after a depot
break;
}
}


Thank you.
Title: Re: [r8293] Load passangers scheduled to go to depot
Post by: prissi on September 25, 2017, 01:11:43 PM
It works, but it will not affect already borded passengers.
Title: Re: [r8293] Load passangers scheduled to go to depot
Post by: Dwachs on September 25, 2017, 02:35:47 PM
We could unload the train at the last stop before going to the depot.
Title: Re: [r8293] Load passangers scheduled to go to depot
Post by: Leartin on September 25, 2017, 06:07:35 PM
Quote from: Dwachs on September 25, 2017, 02:35:47 PM
We could unload the train at the last stop before going to the depot.

Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?
Title: Re: [r8293] Load passangers scheduled to go to depot
Post by: HyperSim on September 26, 2017, 12:25:58 AM
Quote from: Leartin on September 25, 2017, 06:07:35 PM
Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?

I think the latter way is better, but the current way is not so bad.
They should be unloaded at the last stop before depot if it is not so hard to fix.
Title: Re: [r8293] Load passangers scheduled to go to depot
Post by: Ters on September 26, 2017, 05:20:54 AM
Quote from: Leartin on September 25, 2017, 06:07:35 PM
Just for them to disappear, or could they actually be transferred to the station, keeping their current routing?

If they just disappear, they might as well disappear in the depot as they do already.