[Bug v3.8] minivec_tpl<T>::resize(), new size 256 too large (>255)

[dantedarkstar]

As the topic says, I found the following bug.

After loading old save game (with large passenger network) and running it for almost a month without touching anything I started adjusting the network to new balance that settled after this month. When working, I suddenly get this:

FATAL ERROR: minivec_tpl<T>::resize()
new size 256 too large (>255)

The error is repeatable. Everytime I load the save and wait it happens on the very same day (10 Dec, the save is at 1 Dec).
The save is too large to upload here, but if it would help you to have it, should I use http://simutrans-germany.com/files/ to upload it (I don't have any password or anything there, just found it few moments ago) ? Or some other place ?
I'm running pak128-1.4.5--102.0. But generally it works. The crashing save was made after 1 month of fast forwarding after all and it worked correctly during this time.

[knightly]

Hi Dantedarkstar,

You don't need to register at http://simutrans-germany.com/files/ to upload files. You may use any user name and password -- they are just for identifying your uploaded files and for you to managed them later on (e.g. delete them before the file expires).

[jamespetts]

Dante,

thank you very much for the bug report! If you can upload your saved game, I should be able to track down and fix the bug, which, judging by the message, I suspect is caused by using a minivec where a full vector should be used. With the saved game, I can find out where I am using the wrong type of vector, and change it. Thank you for your feedback!

[dantedarkstar]

You replied as I was in the process of uploading the save (thanks Knightly for explaining)

Here it is:
http://simutrans-germany.com/files/upload/Q5exp_57.sve
(I set it to be valid for 7 days)

It always crashes for me on 10 Dec, although not always on the same hour. Just fast forward.
Maybe it's be something with the number of different passengers (destination/origin) that are on the stop or something like that ? (since tracking origin/destination makes a lot more types than just destination as in standard simutrans, and I suspects the hub architecture of the transport network that I have there might result in many different passengers being there)
It's just a thought. I don't know if minivec is even used for that

[jamespetts]

Thank you very much. Problem found and fixed for the next version :-)

[dantedarkstar]

So, where was this minivec used where you needed full vector ? Just out of curiosity
(I don't mean in what function or whatever, I'm not familiar with simutrans code, just was that passenger list or something else)

[jamespetts]

It was the list of goods/passenger packets on board a convoy.

[dantedarkstar]

Ahh, onboard. Then this was one of my express trains or passenger liners. He was the culprit ! 
Or maybe a hero ?

[jamespetts]

Fixed in version 3.9.