The International Simutrans Forum

 

Author Topic: Bug: Cannot build dock (Vehicles cannot be removed)  (Read 1773 times)

0 Members and 1 Guest are viewing this topic.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2499
  • Languages: EN
Bug: Cannot build dock (Vehicles cannot be removed)
« on: December 19, 2017, 07:44:26 AM »
As a small port grows into a larger port it is often required to extend it to cope with the larger traffic. However often the traffic that visits it prevents one from building the extensions for some reason.

Here is some ASCII art showing the problem.
Code: [Select]
D = dock
N = where new dock is trying to be built
S = ship
T = ship tail (holds)
W = water
C = coast

Dock with no ships, N can be built.
WWWW
WWWW
CDNC

Dock with ship in orientation allowing N to be built
WTWW
WSWW
CDNC

Dock with ship in orientation that prevents N from being built with a "Vehicles cannot be removed" error message.
WWWW
WSTW
CDNC

Since the ship is already interacting with the dock I see no reason why it should prevent the enlargement of the dock to the sides.
« Last Edit: January 10, 2018, 07:01:08 AM by DrSuperGood »

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Devotee
  • *
  • Posts: 17653
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #1 on: December 19, 2017, 11:36:29 AM »
Can you identify a particular place on the online game where this issue can reliably be reproduced, or alternatively upload a saved game in which this issue can reliably be reproduced at a particular place and time?

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2499
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #2 on: January 10, 2018, 07:01:01 AM »
I have set up a demonstration for this bug on the server game @1528,505. The signs mark where trying to place an expansion to the dock fails due to "Vehicles cannot be removed".

It is possible this is a problem in Standard as well, just standard paksets do not have many multi-tile ships so it is never encountered.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Devotee
  • *
  • Posts: 17653
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #3 on: January 10, 2018, 07:44:52 PM »
I have managed to reproduce this in Standard, so I have moved this to the Standard bug reports board. I should note that there are multi-tile ships in the Standard version of Pak128.Britain.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2499
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #4 on: January 11, 2018, 01:26:14 AM »
Does anyone still need the demonstration on the experimental server?

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Devotee
  • *
  • Posts: 17653
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #5 on: January 11, 2018, 11:10:27 AM »
I do not think so.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9240
  • Languages: De,EN,JP
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #6 on: January 12, 2018, 05:29:41 AM »
No considered an error, since before building a dock everything is removed. And ships are non-removal items. In realisty you cannot build a dock on a ship, you need to remove it first too.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2499
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #7 on: January 12, 2018, 05:53:07 AM »
The problem is that the dock is not being built over any ships. The dock is trying to be built on the shore (land) while a ship tail (cargo holds) is in front of it. I could understand if the dock in question had a peer as that would get built over the ship, however it does not.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5317
  • Languages: EN, NO
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #8 on: January 12, 2018, 06:35:28 AM »
In other words, it is not the dock/pier itself that is conflicting with the unremovable objects, but the invisible stops on water tiles surrounding it?

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2499
  • Languages: EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #9 on: January 12, 2018, 06:45:58 AM »
Quote
but the invisible stops on water tiles surrounding it?
Sounds about right.

Why must it remove all objects in the way? Surely it could ignore trying to remove all convoys.

Offline Leartin

  • Devotee
  • *
  • Posts: 1055
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #10 on: January 12, 2018, 06:56:05 AM »
One could question why tiles on water need to be checked for objects at all, given that water objects are not 'solid'?

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5317
  • Languages: EN, NO
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #11 on: January 12, 2018, 04:32:52 PM »
It is after all possible to build train platforms and bus stops on tiles with vehicles on them.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4470
  • Languages: EN, DE, AT
Re: Bug: Cannot build dock (Vehicles cannot be removed)
« Reply #12 on: January 13, 2018, 10:13:30 AM »
should be fixed with r8368.