Bug: Overcapacity stage coach.

[DrSuperGood]

Stage coach base capacities:
Medium: 8
High: 4
Total: 12

Reassigned capacities, used by the convoys pictured:
Low: 8
Medium: 4
Total: 12

Images shows a stage coach with 16/12 and 14/12. The 14/12 shows that it has loaded 8/8 low (correct), 0/4 medium and 6/? High.

My theory is that the loading logic is using inconsistent class values when calculating load capacities. Specificly in this case it makes a high class capacity type and uses the low class capacity value for it. Hence from the logic point of view the convoy has 8 low and 8 high capacity and so 16 people can fit into a 12 capacity coach.

The correct behaviour is that the high class passengers should be using the 4 medium capacity, if class logic permits, as there is no high class for them on this convoy.

[ACarlotti]

This is a known bug - see also:
https://forum.simutrans.com/index.php?topic=17865.0
https://forum.simutrans.com/index.php?topic=17604.msg168460#msg168460

I have been working to fix this, although my efforts were somwhat impeded by possible inconsistencies in the stored values of number_of_classes.
https://forum.simutrans.com/index.php?topic=17874.0

I believe I have now fixed the latter (subject to testing), and should hopefully be able to finish fixing the former within the next day or two.

[jamespetts]

Thank you for the report. Normally, I should ask for a saved game in which the problem can reliably be reproduced so that I can find and fix the problem, but I note that  ACarlotti believes that he has identified the probable cause of that and is planning to fix it.

In the circumstances, I suggest that we wait and see whether this does indeed succeed in fixing the problem; if not, then I will need a saved game in which this can reliably be reproduced to track it down.

ACarlotti - thank you very much for your work towards fixing this issue: it is much appreciated.

[jamespetts]

Can I check whether this is still an issue?

[DrSuperGood]

From what I can tell this seems fixed. Have not noticed any over capacity or wrong class numbers in convoy info panels recently.