The International Simutrans Forum

PakSets and Customization => Pak128.Britain => Topic started by: neroden on May 13, 2012, 07:01:36 PM

Title: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 13, 2012, 07:01:36 PM
Gaaaaah....

OK.  This is a patch.  It's zipped because it's large.  First unzip it. Then apply by going into the top directory for pak128.britain and running "patch -p1 air-simutranslator.diff".

This does several things:
(1) It adds a "simutranslator" target to the Makefile, which builds zip files suitable to upload to simutranslator.
(2) It renames 3 of the air/ files for consistency (these were driving me nuts).
(3) It adds correct terminators (---) at the bottom of files for the benefit of simutranslator, which needs them.
(4) It converts the Makefile and everything in air/ back to Windows/UNIX/Linux line endings.  They got "DOSified" by accident at some point.

You need to figure out how to stop committing files with DOS line endings.  What text editor are you using?  Rule 1: do not use Notepad.  If it's anything else (Wordpad etc.), I can probably explain how to get it working in Windows/UNIX/Linux mode.

It's also possible that TortoiseSVN is causing the problems.  If so, it's more tedious to fix, but there is a way and I can explain it.

(EDIT: if you ever switch entirely to git, I know how to make things work there too; it's even easier.)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 13, 2012, 09:31:49 PM
For reference, I use MSVC++ Express both for the code and for the pakset work.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 13, 2012, 10:22:38 PM
OK, this is a followup patch.

I believe it is not wise to have spaces in object names.  It causes makeobj to generate pak files with spaces in their names, which in turn causes trouble on UNIX systems sometimes.  Although it seems to work right now, it's not a good idea.

So this patch removes the spaces from the internal name of the Ford Trimotor.  It must be applied AFTER the large patch (due to the annoying business with DOS line endings).

EDIT: James Petts, I don't think you've introduced any DOS line endings lately, though I'll check; I believe James Hood has, so that was addressed to him.

EDIT 2: I have now updated Simutranslator with all the new aircraft and new English translations for all of them.  If I can get these patches into pak128.britain (standard), I will then move on to the remaining directories, one at a time, and when I'm done I'll extract a new full set of translations from Simutranslator to put into svn.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 13, 2012, 10:41:09 PM
Ahh, thank you for the Ford Trimotor patch. I had already fixed this on Experimental, using the name: Ford-Trimotor-NSA. Perhaps this would be an easier and shorter version to use on Standard, too?
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 13, 2012, 11:41:00 PM
Quote from: jamespetts on May 13, 2012, 10:41:09 PM
Ahh, thank you for the Ford Trimotor patch. I had already fixed this on Experimental, using the name: Ford-Trimotor-NSA. Perhaps this would be an easier and shorter version to use on Standard, too?

Hmm.  That's up to James Hood.  I supposed that most people wouldn't know what NSA meant and figured that the full version of the name should be included because of that. 
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 13, 2012, 11:43:34 PM
Ahh, but people woulndn't see "NSA" in game, as it'd be translated. In en.tab, there is the line:


Ford-Trimotor-NSA
Ford Trimotor - Northern & Scottish Airways
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 12:21:24 AM
Ah... but most of the English translations for airplane names don't give the airline name.  :-)  They actively remove it, in fact.

I figured this was a deliberate stylistic choice which I was trying to maintain.  If you want the airline name in the Trimotor, we should insert it in the translations for all the others too. 

I figured the airline name was just a reminder to us, the programmers, regarding what livery was used in the artwork.

EDIT: NEW PATCH.  attractions/stone-attractions.dat had one annoying typo, which I want to fix before it's too late (Cemetry->Cemetery).  Of course, this file's in DOS format so the patch changes EVERY SINGLE LINE again, and I have to zip the patch.   If the files in standard were all "de-DOSed" I could submit shorter patches.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 14, 2012, 12:22:39 AM
Ahh, yes, you're right about the airline names, actually - I'd forgotten about that. I shall change it now.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 12:49:40 AM
OK, question: why is there a "Fountain" in the stone-attractions, and another "Small Fountain" as a separate file, with very similar graphics and completely different .dat contents?  Though I do think multiple fountains should exist, I don't think they should have the same artwork and wildly different stats.

EDIT: OK, confusion: it's a "Small Fountain" in the stone-attractions as a "cur", and a "Fountain" in its own file as a "mon".  So I guess that's the difference...
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 14, 2012, 12:53:10 AM
Hmm, if they have the exact same graphics, this is probably an error. Was this duplication in Standard, Experimental, or both?
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 01:23:35 AM
Quote from: jamespetts on May 14, 2012, 12:53:10 AM
Hmm, if they have the exact same graphics, this is probably an error. Was this duplication in Standard, Experimental, or both?

See my edit above; graphics aren't exactly the same (not bit-for-bit identical), just practically the same.  One's a "mon" and the other's a "cur", which I suppose is the reason here... I still don't get it.  This is in Standard.

EDIT: while I'm poking around, anyone have some naming ideas to differentiate the 4 Cathedrals, 2 Abbeys, and 2 Castles in the translations?  For now I'm sticking with the boring "Cathedral" for all the catehdrals, but....

EDIT 2: Just finished going through attractions for standard.  That was tedious.  James Petts, if you are interested in these fixes, they're on the standard-fixes branch of my github (though you'll have to cherry-pick them, to avoid a full merge from standard, which might break stuff).

Now I await TheHood's integration of my patches.  And I go to sleep.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 14, 2012, 01:47:48 AM
I tend to prefer to use the same name: there's no reason in principle to distinguish them - the different objects are there for graphical variety, not because they are fundamentally different types of buildings.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 01:59:27 AM
Quote from: jamespetts on May 14, 2012, 01:47:48 AM
I tend to prefer to use the same name: there's no reason in principle to distinguish them - the different objects are there for graphical variety, not because they are fundamentally different types of buildings.

I got four cathedrals in one city, which was "interesting", and I proceeded to start renaming them (to things like "Rose Cathedral" and "St Savior Cathedral").  But sure, we can leave them as "Cathedral".
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: Milko on May 14, 2012, 09:46:23 AM
Hello neroden

Quote from: neroden on May 13, 2012, 07:01:36 PM
You need to figure out how to stop committing files with DOS line endings.  What text editor are you using?  Rule 1: do not use Notepad.  If it's anything else (Wordpad etc.), I can probably explain how to get it working in Windows/UNIX/Linux mode.

I'm designing planes for pakBritain. I put the files "dat" using wordpad of windows. I am attaching files to messages in the forum instead. I have to use precautions to place the files (de-DOSed)? Or precautions must be used by him in github which loads the files?

Giuseppe
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 04:30:36 PM
Quote from: Milko on May 14, 2012, 09:46:23 AM
Hello neroden

I'm designing planes for pakBritain. I put the files "dat" using wordpad of windows. I am attaching files to messages in the forum instead. I have to use precautions to place the files (de-DOSed)? Or precautions must be used by him in github which loads the files?

Giuseppe

It's really James Hood's responsibility to get this right when he checks the files into the repository, not your responsibility.  So I need to know what tools he's using.

Wordpad should be able to save files with UNIX line endings anyway.  I'm having trouble finding the documentation on this, and I don't use Windows any more so I can't check it myself.  So it might not.

If you get something like the free Notepad++ (or practically any other text editor apart from the ones which come with Windows), you can "Save As... UNIX Format" and guarantee that you're getting UNIX line endings.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 14, 2012, 04:33:01 PM
Quote from: jamespetts on May 13, 2012, 09:31:49 PM
For reference, I use MSVC++ Express both for the code and for the pakset work.

Which version?

I think we solved your situation with git options.  Git has an option to basically force all check-ins to have UNIX line endings.
With SVN, you have to set the option on *every single text file individually*.  Which we should probably do, but that's tedious, isn't it?
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: kierongreen on May 14, 2012, 05:40:38 PM
QuoteWith SVN, you have to set the option on *every single text file individually*.  Which we should probably do, but that's tedious, isn't it?
If that's only once I don't see that as being overly tedious, but yes if it's causing problems would be an idea to change.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: VS on May 14, 2012, 09:21:48 PM
Well, with tortoise you can select a number of files and set the property on them all, so no problem there ;)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on May 14, 2012, 09:23:30 PM
neroden,

Thanks for the patches - I appreciate the need for consistency and your efforts at attempting to resolve it. Unfortunately right now I don't have time to do anything about this (nor do I know when that might be). I'm happy for other people to make these changes in SVN, but that may cause problems down the line when I modify stuff and "undo" the changes. I know that's a frustrating answer - sorry.

For now I can explain what I do - I try to be systematic but bear in mind that nearly everything I've done in pak128.Britain has been self-taught and driven by necessity/what I or others wanted at the time so it's a bit of a mish-mash of processes cobbled together to suit immediate needs. I do this for fun and not as a professional coder and although I appreciate why your patch is important please understand if it's not top of my to-do list (especially if it involves changing 1000 settings one-by-one!).

1) draw stuff in blender/edit in gimp
2) write dat file in WordPad (although some of the older ones will be left over from a previous computer which ran linux and I used kwrite)
3) compile with makeobj and test
4) copy files over to SVN directory
5) TortoiseSVN update/commit to sourceforge SVN*
6) wait for nightly build to do it's business/occasionally make manual release on sourceforge with new version number

*I use sourceforge because that's what the other paksets use and that's what prissi invited me to use. I have no other reasons either way. Blend files exist on github because there is more space for large files on there (so I understand). I've forgotten how to upload stuff there, but have no objection to making that the main repository other than (the large one of) it not being where other simutrans paksets are based.

I'm open to suggestions about what the best way of doing things differently is, but as I say, please bear in mind I get little time for Simutrans and when I do I like to draw new objects rather than tidy up dat files.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 14, 2012, 09:35:40 PM
I recommend using Git instead of SVN. When using Git, one can merge in others' work with very little effort (actually, one can do that to some extent with .patch files for SVN, but it's not quite the same, and can't deal with non-text files, deleting files, or changing the structure, as far as I am aware).
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on May 14, 2012, 09:40:00 PM
Quote from: jamespetts on May 14, 2012, 09:35:40 PM
I recommend using Git instead of SVN. When using Git, one can merge in others' work with very little effort (actually, one can do that to some extent with .patch files for SVN, but it's not quite the same, and can't deal with non-text files, deleting files, or changing the structure, as far as I am aware).

How would that work with Sourceforge and the other paksets/nightly builds? I'd rather not complicate that too much as that is what people play/download...
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: jamespetts on May 14, 2012, 10:09:18 PM
Hmm - I'm not sure about Sourceforge, since I don't really use it. Nightly builds can be set up to work with Git, as far as I understand, but I suppose that that would require the co-operation of those who administer them.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: sdog on May 15, 2012, 12:56:02 AM
Should it be difficult or inconvenient for Ansgar to build nightlies from git, i could volunteer to do so. (only two caveat and one precondition. The Makefile needs to be maintained, i won't start playing around with those python scripts. I can't host it on the machine i build, this would most likely not work well with university regulations. give me any place to scp or sftp it to, or if cloudspace is acceptable this works. I am not experienced with doing such things, i have an idea what i'm doing though.)


If you want i can start building nightlies from the github mirror within a week or so, that is as a proof of concept.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 15, 2012, 08:27:46 PM
OK, given your workflow I would recommend switching to github for your primary repository -- if you can tolerate using the command line.  It's a little bit of a pain to set up under Windows, but it only needs to be set up ONCE and it should make merging changes from other people a lot easier.  You've already got an account on github and you already have a repository there. 

If you haven't got git installed on your home computer, here's a guide for the preferred configuration with github:
http://help.github.com/win-set-up-git/ (http://help.github.com/win-set-up-git/)

This configuration automatically fixes line endings on check-in.  The business with SSH keys is basically about secure communication with github; you must have done a bunch of this in order to upload the blend files, already.

Then, open up "Git Bash" whenever you need to type something at the command line in git.

Git workflow is a little bit different from Subversion workflow.  James Petts is using it, but it might take some practice to get used to it.

Basically, with git, you have your own copy of the repository locally. (There's a little setup involved in doing this the first time, which I can explain if you decide to do it; I don't remember it off the top of my head because I only had to do it once.)  So in order to check in data, you have to first tell git to check it in locally with git commit <names of new or modified files> and then push it to github with git push origin-- Not quite as convenient as TortoiseSVN, I admit.

But the nice part about it is how easy it is to merge other people's changes if they're also using git.
For instance, you set up a reference to my repository with
git remote add neroden git://github.com/neroden/simutrans-pak128.britain.git

And then in future you can merge an entire pack of changes from me really easily.  If I ask you to merge my "standard-fixes" changes, you type
git pull neroden standard-fixes
to add the changes locally, and then
git push origin to send it back to github.

If I somehow mess things up and the "pull" causes merge conflicts, run
git reset --hard and tell me to fix my patch ;)

Now, one alternative is to give me SVN write access, in which case I just go in and fix this stuff myself.  But with git, you don't have to do that.  You can pull one particular set of changes from me (or anyone else using git) really easily, without having to give me generic privileges to write to the repository.

sdog: I'm already maintaining the Makefile.  Also, is anyone building nightlies for experimental?  Experimental is already based in git.  It would definitely be wise to be able to build nightlies from git for that reason alone.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: prissi on May 15, 2012, 09:33:00 PM
(Sidenote: Actively pull means he has to keep track also of your stuff. Makes even more work for a maintainer ... )

But on topic: For sourceforge SVN access, you need a sourceforge account. If you are registered there, I can give it to your too.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on May 15, 2012, 10:01:58 PM
Geez, I don't remember whether I have a sourceforge account... uh-oh.  My username is taken, which means that I probably did register an account in the past.  But I don't know what email address it was registered with and I probably don't have that email address any more.  Gaaah... well, I'll try the non-automated recovery process.  Maybe I'll have a sourceforge account in a day or two.

Well, it's up to TheHood.  If you (prissi) are willing to give me SVN access, and TheHood is willing to authorize me to commit to pak128.britain without review, that will work.

I've gotten kind of spoiled by how cheap branching is with git, of course.  Subversion is perfectly nice, but branching is expensive, and file renames don't merge easily.  And in this case, I will have to go through and mark every single .dat file with the line ending property.  Although I can automate that, I have to rerun the script every time a new file is added.

EDIT: Anyway, I've made it through the 'boats' translations.  That's three directories...

EDIT 2: Aha.  I figured out how TheHood can avoid committing new files with DOS line endings in SVN.  (I still have to set properties on every single one of the old ones individually.)  Anyway, TheHood, look at this page:

http://www.mediawiki.org/wiki/Subversion/auto-props

In the auto-props section, in addition to the adding the ones listed there, you will want a line:
*.dat = svn:eol-style=...
I think we don't want "native" we want "all lf all the time" but I have to run, I'll figure out the exact code later...
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: VS on May 16, 2012, 08:50:42 AM
I have write access, too, and can mark the files for you, if you make a list.

I am not sure what files you want to have as all-LF, but pak128 uses native everywhere, except translations, and had no problems, ever. And translations need LFs only because translator exports them as LF, so this way you avoid conversion, just export and overwrite the files.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: prissi on May 16, 2012, 02:39:25 PM
I am not sure what they are currently with pak64; but simutrans (and translator) can handle both line endings.

In principle there are hooks for this; our sourcecode repo ensures all this (and a lot of other stuff with spaces) but in sourceforge there is no easy way with hooks.

But with a script it is dead easy, just do "svn propset svn:eol-styl native *.dat" in every directly and you are set.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 01, 2012, 03:04:31 AM
Native everywhere is fine (that means they're LF in the repo ).   The problem is having a mix of files, some LF, some CR-LF...

So this means TheHood should follow the instructions above regarding "auto props" and add
*.dat = svn:eol-style=native

Anyway.  I have finally recovered my sourceforge account (THAT took a long time).  The username is "neroden".  I can go through and start doing the fixes in svn if I get write access.

So, what has to be done to get write access?  This is already slower than using git ;-)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 01, 2012, 03:05:32 AM
Quote from: VS on May 16, 2012, 08:50:42 AM
I have write access, too, and can mark the files for you, if you make a list.

*.dat.  Every dat file should be 'native' (which means LF in the repo and on Linux).
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: Dwachs on June 01, 2012, 07:05:07 AM
Quote from: neroden on June 01, 2012, 03:04:31 AM
So, what has to be done to get write access?
Send an email to one of the administrators? You should have svn access as of now ;)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on June 07, 2012, 12:10:00 PM
Quote from: neroden on June 01, 2012, 03:04:31 AM
Native everywhere is fine (that means they're LF in the repo ).   The problem is having a mix of files, some LF, some CR-LF...

So this means TheHood should follow the instructions above regarding "auto props" and add
*.dat = svn:eol-style=native

Anyway.  I have finally recovered my sourceforge account (THAT took a long time).  The username is "neroden".  I can go through and start doing the fixes in svn if I get write access.

So, what has to be done to get write access?  This is already slower than using git ;)

OK I've changed this. Can I just confirm this should now mean all future commits are in the right format, i.e. no DOS line-endings?
I'm now going to have a go at applying the various patches.

EDIT: for some reason absolutely nothing happens when I try to apply the patch using either TortoiseMerge or GnuWin patch on the command line. I'd be grateful if someone who knows what they are doing could apply these patches.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 12, 2012, 05:44:46 AM
I'll apply them.  I've been seriously distracted by changing computers among other things, but I can apply my own patches.   ;)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on June 12, 2012, 08:07:48 AM
Excellent. Can you also check when you are doing it that the latest things I have uploaded (e.g. boeing 747) are in the correct line ending format?
Perhaps, to avoid repeating the need for such patches in the future, could you produce a checklist of things we need ensure in a dat file?
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: Milko on June 12, 2012, 09:34:03 AM
Hello Neroden

Quote from: neroden on May 15, 2012, 08:27:46 PM
If you haven't got git installed on your home computer, here's a guide for the preferred configuration with github:
http://help.github.com/win-set-up-git/ (http://help.github.com/win-set-up-git/)

This configuration automatically fixes line endings on check-in.  The business with SSH keys is basically about secure communication with github; you must have done a bunch of this in order to upload the blend files, already.

I set up git locally on my PC. I use git gui.

I'm modifing some pak128brit stuff and I'm modifing existing files using microsoft wordpad.

If I use git gui for uploading the changes I will insert more errors at line endings?

Thank's

Giuseppe
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 13, 2012, 02:17:15 AM
Quote from: The Hood on June 07, 2012, 12:10:00 PM
OK I've changed this. Can I just confirm this should now mean all future commits are in the right format, i.e. no DOS line-endings?

Sadly, no.  New files will probably have DOS line endings.  You need to do the following.

First, find the configuration settings in TortoiseSVN, using these instructions:
http://www.mediawiki.org/wiki/Subversion/auto-props (http://www.mediawiki.org/wiki/Subversion/auto-props)

Then, In [miscellany] uncomment/add this line:

enable-auto-props = yes

In the [auto-props] section, uncomment the default bits and also add:
*.dat = svn:eol-style=native

That should guarantee that newly added .dat files have standard line endings.

I just corrected everything currently in the pak128.Britain repository using a script, so existing files should be good as of now.

Milko: if you're using Windows, you need to make sure that you have the "core.autocrlf" set to "true" in your git settings. (See https://help.github.com/articles/dealing-with-line-endings#platform-windows (https://help.github.com/articles/dealing-with-line-endings#platform-windows) ).

(edited to fix significant typo)
EDIT 2:
I'm going to wait a little bit after fixing the line endings before applying my patches, to let the fix propagate to git and to make sure no trouble got introduced.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on June 13, 2012, 07:15:56 AM
OK I think I made some of those changes but not all. Will check when I get chance. Thanks for sorting it all out!
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 13, 2012, 08:51:41 PM
I'm having an odd problem.  The changes committed to SVN aren't propagating to the git mirror.  Aburch, are you anywhere?

Edit: is Aburch on github the same person as "ansgar" here?
Edit 2: oooh-kay, this is a much worse problem than I thought.  The Git mirror is working fine.  My commit has failed to register at Sourceforge.  Even though my local copy SAYS that it's committed.

I've never had this sort of problem with SVN before; are you using some sort of weird configuration?  Can you just switch to git already?

Edit 3: OK, it's shown up on Sourceforge.  Now I just have to figure out when it's going to show up in the git mirror and then I can recheck my patches....

Edit 4: Looks like I may have committed just after the daily update, so I may have to wait six more hours.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: prissi on June 13, 2012, 10:05:15 PM
As far as I know, the paksets are not transferred to github.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 14, 2012, 02:51:45 AM
pak128.britain has a mirror.

EDIT:
https://github.com/aburch/simutrans-pak128.britain

It doesn't seem to have updated, and it's been 24 hours.  I guess I need to ask Ansgar how often it updates.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 14, 2012, 09:29:47 PM
OK, so how do I contact Ansgar -- is 'aburch' on github the same as ansgar here?

I wait impatiently for a reply.

Please pay attention to how much of my simutrans time has been wasted in trying to get other people to authorize things (close to a year to get a simutranslator account) or even to get them to check that their scripts are working (the git mirror of pak128.britain was working six days ago, why did it break?)
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: VS on June 14, 2012, 09:42:24 PM
Yes for the first question. His full name is Ansgar Burchardt and he is all over the internets.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 15, 2012, 01:24:04 AM
Quote from: VS on June 14, 2012, 09:42:24 PM
Yes for the first question. His full name is Ansgar Burchardt and he is all over the internets.

Thank you.  I didn't know how many people there were named Ansgar Burchardt -- for all I know it's like John Smith. :-)

Anyway, I sent him a private forum message, we'll see if he can kick the mirror into working perhaps.  Sigh.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 16, 2012, 06:18:40 PM
...and we're good (thanks, Ansgar).  But now I have to run off.  I'll try to get the patches re-verified and in today or tomorrow.
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 17, 2012, 02:49:37 PM
OK, they're in.  :whew:
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: The Hood on June 17, 2012, 04:48:57 PM
Thanks. Can you keep an eye on this after my next few commits to see how we are doing?
Title: Re: Big "fix it" patch for simutranslator, and please stop making DOS line endings..
Post by: neroden on June 17, 2012, 10:07:18 PM
Quote from: The Hood on June 17, 2012, 04:48:57 PM
Thanks. Can you keep an eye on this after my next few commits to see how we are doing?

I will do my best.  Please remember to add the terminating line of dashes, by the way; I just fixed two more of these in the air directory.

Edit: and another in bus/parcel-coach.dat.

I think the reason simutranslator cares is due to its processing method.