Is type=dock not available yet ?

[z9999+]

It seems that current code supports type=dock stations, but I cannot build it.
Is type=dock already available or not ? There is nothing about it in history.txt.

- I used makeobj 55.4.
- I used pak64 harbor .dat and changed type from "habour" to "dock".
- I tried both Dims=1,1,4 dock and Dims=1,4,4 dock.
- I also added "water" to climates.
- I added toolbar[6][11]=buildings(36,3) to menuconf.tab.

But I cannot build it on map at all. "No suitable ground" error happens.
Does anyone have a sample pak which works correctly ?

[Frank]

... dock is obsolete, you would rather define it as waytype=water and type=stop

[Dwachs]

The 'type=dock' is intended to be harbours that can be build on flat coast tiles. Not sure whether it *works* as intended.

[z9999+]

Thank you both.
Maybe "obsolete" means that it does not work.

[Dwachs]

type=dock was added in r7519 to be able to build harbours on flat shores, which now appear as side-effect of the (not so new anymore) climate system.

I think, prissi meant the obsolete 'wharf' type.

So this bug report is that these harbours cannot be built at all (?)

[z9999+]

Can you build harbours on flat shores ?
Strange enough, I cannot build it. (120.1.2 and pak64)
Which harbor and which pakset are you using ?

I cannot build both harbour(haus_besch_t::dock) and dock(haus_besch_t::flat_dock) on flat shores.

[Dwachs]

I have never tested it. As far as I know, there is no pakset that uses this feature. Will check tonight.

Edit: Here is a patch (apply with 'patch -p3'). Please test. I also attach a pak file for a harbour to be build on flat land (it is a remix of harbour and road graphics from pak64).

As the possible direction of flat-harbours are not uniquely determined by the landscape, there is the possiblity to ctrl-click on the icon to choose rotation (like for station extension buildings).

To get the icon for the dock add this line to pak64 menuconf.tab

Code Select Expand


toolbar[6][11]=buildings(36,3)

(toolindices might be different in different paksets)

[z9999+]

Thank you for testing and fixing.
Unfortunatelly, I do not have build environment on my current PC anymore.
So, I will try when it is released.

But, thanks again anyway. 

[Dwachs]

I will not submit this to the svn as I do not know how the building of harbours on flat tiles was intended.

[prissi]

SInce you could achieve something simular with a custom water factory producing nothing I would say why not. It is up to the pak set to have those.

[Dwachs]

This is now incorporated in r7737-7739.

Some of the pak64 harbour graphics would also perfectly work as flat_dock objects, which do not require a sloped tile to build.

[prissi]

You are invited to turn one of them into a dock then. I will be very busy this weekend.

[z9999+]

Thank you.
Quick test on r7742.

I can build on artificial slope.
Maybe it needs to check tile height difference.

[Dwachs]

thanks for checking. Should be corrected in r7744. This also affected the harbour buildings that need to be built on a slope