The International Simutrans Forum

PakSets and Customization => Pak128 Bug Reports => Pak128 => Pak128 Solved Bug Reports => Topic started by: uci on April 08, 2011, 09:24:51 AM

Title: special construction and map editing tools
Post by: uci on April 08, 2011, 09:24:51 AM
I would like to highlight here some inconsistencies (in my opinion):

1. "plant trees." tool appears both in special construction tab and
map editing tab. It can be removed from the later, since there
exist anyway a more specialized version of it, called "plant trees" dialog.
Also, the similarity of these two names is a little unfortunate.

2. "Power line bridge" tool does not have an image drawn over the icon.

3. "Enlarge map tool" should be moved from special construction tab to
map editing tab, since it has a more radical effect on the map (like pak64).

What do you think?
Title: Re: special construction and map editing tools
Post by: VS on April 08, 2011, 06:32:47 PM
(2) is a known issue, we're sort of waiting for someone to provide the graphic that says "power line" & "bridge" & fits in 32*32 pixels. I gave up... ::( Anyway, I would leave this open for now, since Fabio will be providing a whole set of new bridges and they will likely use a icon pictogram to show that they are bridges. That could be reused here, making the icon simply a power line and a bridge symbol. So, waiting for the pictogram discussion when it comes up.

The other two are valid issues, too. I'm not that good with this stuff though, so let's see if I can redirect this to the expert :) Ditto for your other report.
Title: Re: special construction and map editing tools
Post by: uci on April 09, 2011, 09:06:14 AM
With your permission I attach here a configuration
file (menuconf.tab) which corrects some errors
reported in this topic and here
http://forum.simutrans.com/index.php?topic=7148.0 (http://forum.simutrans.com/index.php?topic=7148.0)

Changes:
1. plant tree shortcut changed to '$'
2. edit attraction shortcut changed to '\'
3. edit tree shortcut removed
4. "plant trees." tool removed from map editing tab
5. "enlarge map" tool relocated to map editing tab

Hope everything else is OK.
Title: Re: special construction and map editing tools
Post by: VS on April 09, 2011, 05:21:42 PM
Dirk told me that he will look into this soon - I'll leave this to him.
Title: Re: special construction and map editing tools
Post by: DirrrtyDirk on April 13, 2011, 12:05:47 PM
Ok, I fixed a couple of the issues.

The plant tree shortcut was supposed to be a "§", given by pak64* but apparently that doesn't really work anymore - and I'm actually wondering wether we really need a shortcut for that tool anyway... but that's a matter for prissi to solve for pak64 and we will follow.

Same goes for edit attraction shortcut - changed it to current pak64 settings. So "/" is for vehicle tooltips only - and edit attraction no longer has a shortcut of its own.

The simple tree planting tool is now only part of special construction tools, while the "add forest" and the more complex tree planting tool are now part of the map editor only.

Enlarge map icon was moved to map editor toolbar.

Added some icons for sliced view, show grid, zoom in&out and network to main menu bar.



* Since pak64 is the standard pak for simutrans, we try not to divert to far from its settings. A couple of keys are different, but I'd like to keep the numbers of those as small as possible. That's also why I'm not keen on assigning new keys easily - they might be used for new functions of simutrans in pak64 in the future - and we should be able to follow then.
Title: Re: special construction and map editing tools
Post by: uci on April 13, 2011, 01:30:29 PM
If I understand correctly, neither "plant trees" nor "plant trees."
tools will have a working shortcut. My personal preference
is that the simple tool "plant trees." should have a shortcut
(since it belongs to all players) and the complex "plant trees"
should not. Anyway, these can be customized locally.

Title: Re: special construction and map editing tools
Post by: DirrrtyDirk on April 13, 2011, 02:10:57 PM
Ok, let's be precise:

We had a broken character for 2 different tools. The shortcut for dialog_tool[23] was simply removed, while the shortcut for general_tool[11] was set  back to pak64 standard, which is the character "§" - but unfortunately it doesn't work in game anymore (in fact, it is not even shown in the key-help in game).

It appears to be broken in both GDI and SDL versions, and in both pak64 and pak128. So it is not a pak128 specific problem. Either the code needs to be fixed, or a different standard key is needed in pak64 (which will then also be used in pak128). For the time being, the corrected standard shortcut remains in the config file - but unfortnately it doesn't work at this time.
Title: Re: special construction and map editing tools
Post by: uci on April 13, 2011, 03:11:39 PM
Quote from: DirrrtyDirk on April 13, 2011, 02:10:57 PM
...which is the character "§" - but unfortunately it doesn't work in game anymore (in fact, it is not even shown in the key-help in game).
a not so common character on some keyboards.

Thanks for the details.
Title: Re: special construction and map editing tools
Post by: Erik on April 19, 2011, 12:13:10 PM
About the 'power line bridge' button icon.
I would make it.
It's radiately simple.

Know someone where I can find the graphics of the normal 'power line' button?
So I can match the colours?
Title: Re: special construction and map editing tools
Post by: uci on April 19, 2011, 04:12:35 PM
Quote from: Erik on April 19, 2011, 12:13:10 PM
Know someone where I can find the graphics of the normal 'power line' button?
So I can match the colours?
At the new home:
http://simutrans.svn.sourceforge.net/viewvc/simutrans/pak128/base/powerlines/way-power_lines-128.png?revision=477&view=markup
Title: Re: special construction and map editing tools
Post by: Erik on April 19, 2011, 04:52:53 PM
Okay thanks.
I have to remember this link.  :D

On the attachment the icon I have build.
Title: Re: special construction and map editing tools
Post by: VS on April 19, 2011, 08:58:33 PM
Included... (but it didn't get into the alpha)