Text only | Text with Images

The International Simutrans Forum

Development => Bug Reports => Topic started by: Yona-TYT on May 27, 2018, 05:21:52 PM

Title: [Schedule Window] The graphical error is still there.
Post by: Yona-TYT on May 27, 2018, 05:21:52 PM

The image says it all.
(https://www.mediafire.com/convkey/648b/bfjz0l22hw2up6a6g.jpg)
Title: Re: [Schedule Window] The graphical error is still there.
Post by: prissi on June 15, 2018, 07:56:18 AM
Could not reproduce
Title: Re: [Schedule Window] The graphical error is still there.
Post by: Yona-TYT on June 16, 2018, 11:10:51 AM
Look at this .  ;)
https://forum.simutrans.com/index.php/topic,16890.0.html
Title: Re: [Schedule Window] The graphical error is still there.
Post by: DrSuperGood on June 16, 2018, 08:21:29 PM
Looks like incorrect clipping logic. The window or list extents for clipping are slightly larger than the actual window size at the bottom of the window.
Title: Re: [Schedule Window] The graphical error is still there.
Post by: Dwachs on June 17, 2018, 07:34:47 AM
That is obvious. The question is, where does something goes wrong. I could not reproduce this either. All the list draw routines use clipped drawing routines, clip rectangles are also correct.
Title: Re: [Schedule Window] The graphical error is still there.
Post by: An_dz on June 17, 2018, 09:29:33 AM
It only happens with the "touch" versions of pak96.comic UI and the new UI based on the forum that is on the screenshot. The problem is that this window assumes that each list item has height LINESPACE.

But if we are to continue working on Dwachs' UI patch, that I really hope we will, that will eventually go away as component heights are returned instead of hard-coded values.
Title: Re: [Schedule Window] The graphical error is still there.
Post by: Dwachs on June 23, 2018, 10:50:15 AM
The problem is that display_text_proportional_len_clip_rgb does *no* clipping of text, only if parameter DT_CLIP is provided.

Edit: fixed in r8516 hopefully
Text only | Text with Images