The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: wackdone on July 11, 2012, 06:38:15 PM

Title: wrong usage of PUSH_CLIP() in gui_tab_panel_t.
Post by: wackdone on July 11, 2012, 06:38:15 PM
argument 'height' for macro PUSH_CLIP() is wrong in gui_tab_panel_t::zeichnen().
4th argument of PUSH_CLIP() must be height of clipping region, not the bottom point of the region.

(Incidentally, 'xx' is correct width of the tabs region. It's right for 3rd argument of PUSH_CLIP()).

Current code of the zeichnen() doesn't draw anything below HEADER_VSIZE.
Therefore, nothing would happen by this mistake.

It's not urgent. It will not immediately change anything in view of the game.
Title: Re: wrong usage of PUSH_CLIP() in gui_tab_panel_t.
Post by: prissi on July 11, 2012, 09:19:51 PM
Thanks, but fixing now is anyway good.
Title: Re: wrong usage of PUSH_CLIP() in gui_tab_panel_t.
Post by: wackdone on July 12, 2012, 06:43:52 AM
Thanks for checking.
I think so, it should be fixed before any trouble.