The International Simutrans Forum

Simutrans Extended => Simutrans-Extended development => Topic started by: MCollett on August 10, 2012, 09:34:39 AM

Title: Location of addons
Post by: MCollett on August 10, 2012, 09:34:39 AM
Recent -devel builds seem to be in two minds about where addons live.  If user addons are selected at startup, files are loaded from whereever/simutrans/addons/paksetname.  But the option to select addons for a pakset isn't even offered unless there (also) exists a folder at whereever/simutrans/paksetname (i.e. not inside the addons folder).  The contents of that folder are ignored, whether or not there is another one inside the addons folder.

Best wishes,
Matthew
Title: Re: Location of addons
Post by: jamespetts on August 10, 2012, 09:52:10 AM
Hmm, I haven't looked at addons in detail. What is the behaviour of the Standard version on which the current -devel branch is built (i.e., 111.2.1)?
Title: Re: Location of addons
Post by: Dwachs on August 10, 2012, 10:05:30 AM
This change broke it:

https://github.com/jamespetts/simutrans-experimental/commit/404c86f12781dd6da3c9a92841ab3c08f49189c6#diff-60

the 'addons' string was lost in this merge (line 124).
Title: Re: Location of addons
Post by: MCollett on August 10, 2012, 10:12:34 AM
Quote from: jamespetts on August 10, 2012, 09:52:10 AM
What is the behaviour of the Standard version on which the current -devel branch is built (i.e., 111.2.1)?

In 111.2.1, addons are recognised and loaded if they are in the addons folder (as announced in this thread (http://forum.simutrans.com/index.php?topic=8990.0)), and ignored otherwise. 

Best wishes,
Matthew
Title: Re: Location of addons
Post by: jamespetts on August 10, 2012, 10:26:55 AM
Thank you very much for that - that is helpful. I think that I have fixed it on my latest -devel commit.
Title: Re: Location of addons
Post by: MCollett on August 19, 2012, 12:14:49 AM
Quote from: jamespetts on August 10, 2012, 10:26:55 AM
I think that I have fixed it on my latest -devel commit.

I've just built the latest version from github (https://github.com/jamespetts/simutrans-experimental/commit/41d9404a2ae966c1889e49efcd00d1a678bdb46a), and it still shows the same symptoms.  I thought that the change made to fix it (https://github.com/jamespetts/simutrans-experimental/commit/ea73ec7521e749030942948a198cca250a45ea5b) would have done the job, but apparently not.

Best wishes,
Matthew
Title: Re: Location of addons
Post by: jamespetts on August 19, 2012, 12:20:46 AM
Are you sure that you built the -devel branch rather than -master?
Title: Re: Location of addons
Post by: MCollett on August 19, 2012, 12:55:25 AM
Quote from: jamespetts on August 19, 2012, 12:20:46 AM
Are you sure that you built the -devel branch rather than -master?

Yes.  The commit code confirms it (41d9404), and I did check in the source file (gui/pakselector)  to see that the relevant change was there; my first thought had been that some subsequent merge might have undone it. 

Best wishes,
Matthew