The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Ashley on September 12, 2012, 07:35:09 PM

Title: Signs remain after player bankrupt
Post by: Ashley on September 12, 2012, 07:35:09 PM
I've noticed on a few of my online maps that people have been able to place signs (the text signs) as the public service player. I specifically lock this player with a password to prevent anyone from being able to access it, and changed the password for the latest generation of maps, yet still someone seems to have found out what it is... Maybe there's some kind of bug which permits this?

E.g. the sign at (583,156) on the current a.128 map...
Title: Re: Possible security bug?
Post by: greenling on September 12, 2012, 08:03:16 PM
Timothy
please let The Placement for textsigns from publicplayer aktiv.It helpfull write importen info for the Another Player.
Title: Re: Possible security bug?
Post by: paichtis on September 12, 2012, 08:13:01 PM
Are these not messages from bankrupted players ?

Title: Re: Possible security bug?
Post by: Ashley on September 12, 2012, 09:03:02 PM
Ah, that could explain it, I didn't test what happens to signs if a player goes bankrupt.
Title: Re: Possible security bug?
Post by: ӔO on September 12, 2012, 09:16:59 PM
pretty sure those public signs are because of bankruptcies.
Title: Re: Possible security bug?
Post by: prissi on September 13, 2012, 05:00:40 AM
Is this desirable? Or should those be removed too?
Title: Re: Possible security bug?
Post by: paichtis on September 13, 2012, 12:50:44 PM
Most of the time they are in the way and meaningless.
So to make it short : it is not desirable (nor logical). At least we schould have a mean to remove them.
Title: Re: Possible security bug?
Post by: Dwachs on September 14, 2012, 03:49:21 PM
Agreed.

This is changed with r5916. Such signs will removed from map if player company is removed.
Title: Re: Signs remain after player bankrupt
Post by: Ashley on September 14, 2012, 09:59:59 PM
Changed the topic title to be more descriptive. Thanks for the fix :)
Title: Re: Signs remain after player bankrupt
Post by: Kevin Ar18 on September 15, 2012, 12:10:38 AM
Quote from: Timothy on September 12, 2012, 07:35:09 PM
I've noticed on a few of my online maps that people have been able to place signs (the text signs) as the public service player. I specifically lock this player with a password to prevent anyone from being able to access it, and changed the password for the latest generation of maps, yet still someone seems to have found out what it is... Maybe there's some kind of bug which permits this?

E.g. the sign at (583,156) on the current a.128 map...
That sign is definitely from a bankrupt player -- I remember who it was and that he went bankrupt.  However, look at these two: (560,180) and (561,155).  They are Spectator signs.  Did you make them or did a player find a bug in the game?
Title: Re: Signs remain after player bankrupt
Post by: Ashley on September 15, 2012, 06:42:08 AM
I made those to test out a few ways I thought players might be able to make signs public :)