The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Fraoch on November 06, 2012, 08:49:59 PM

Title: 112.0 - filters on vehicle list non-functional
Post by: Fraoch on November 06, 2012, 08:49:59 PM
Simutrans 112.0 r6000 with pakset pak128 2.1.0 on Ubuntu Linux 12.10 64-bit.  I'd use a nightly but I don't have the skills to compile it.

Changing anything in the settings box in the filter settings window seems to have no effect.  It's forgotten when the screen is closed and the vehicle list never changes.  The Enable/Disable button seems to have no effect either.

This worked fine in previous versions and I'm using the window the same way.
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: Zeno on November 06, 2012, 09:48:16 PM
I've just tested that too and it seems that everything works until you press the "Enable" button. Then everything seems to get messed up and looks like nothing works there...
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: prissi on November 06, 2012, 09:51:58 PM
Even switching the filter off does not work any more ...
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: Dwachs on November 18, 2012, 11:35:50 AM
should be fixed with r6064. Please test again.
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: prissi on November 18, 2012, 04:18:02 PM
Was already fixed before in r6033.

Why do you switch the filter off during reopening? That way after joining the filters are always off.
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: Dwachs on November 18, 2012, 07:10:36 PM
Could be changed to a static variable. No problem. But then the filter state should also be preserved, which is not the case atm.

The problem with not initializing was that then the boolean variable had strange values, ie something like 241 (not 0 or 1). Then pressing the toggle-filter button had no effect.
Title: Re: 112.0 - filters on vehicle list non-functional
Post by: prissi on November 18, 2012, 07:45:11 PM
Ahh, I see. Indeed, my fault. Since the other setting are preserved (they are static), maybe this should be made static too?