The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: kierongreen on December 09, 2012, 10:59:02 PM

Title: compile errors 6161
Post by: kierongreen on December 09, 2012, 10:59:02 PM
network_cmd_ingame.cc version 6161 doesn't compile under mingw as chdir is not recognised. Including unistd.h fixes this issue but I don't know if that is the correct solution...

Works fine compiling under normal Linux.

makeobj.cc doesn't compile either as init_logging has the wrong number of parameters.
Title: Re: compile errors 6161
Post by: Dwachs on December 10, 2012, 07:30:01 PM
r6163 does not compile, too.
Title: Re: compile errors 6161
Post by: TurfIt on December 10, 2012, 11:09:15 PM
Changed pos.z to get_pos().z to allow 6163 compile. Not sure if this was what was intended....
Title: Re: compile errors 6161
Post by: Ters on December 11, 2012, 05:23:40 AM
Maybe ding_t::get_pos() should return const koord3d & and not koord3d to avoid copying the return value, but the compiler has a good chance of figuring out that such copying can be skipped here itself.
Title: Re: compile errors 6161
Post by: Dwachs on December 11, 2012, 06:43:47 AM
Quote from: TurfIt on December 10, 2012, 11:09:15 PM
Changed pos.z to get_pos().z to allow 6163 compile. Not sure if this was what was intended....
Iirc, the value of pos is NOT yet initialized in rdwr, it is available upon call to laden_abschliessen ... This check should be moved to laden_abschliessen instead.
Title: Re: compile errors 6161
Post by: prissi on December 11, 2012, 09:14:07 AM
Ok, r6170 should work now.
Title: Re: compile errors 6161
Post by: TurfIt on December 13, 2012, 01:11:37 AM
simrand is not allowed in multithreaded laden_abschliessen...
Title: Re: compile errors 6161
Post by: prissi on December 13, 2012, 09:00:16 AM
Ok, r6175 might be anyway desync often on load ...

EDIT: no code in laden_abschliessen anyway any more.