The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: Simppe on January 09, 2009, 08:14:06 AM

Title: Link to line management from station/stop details window
Post by: Simppe on January 09, 2009, 08:14:06 AM
I was just playing simutrans and suddenly realized that I needed to change destination platform for several lines serving one particular station so that the traffic would flow more easily. So I opened the station details to see which lines served the station and then it hit, it would be nice to have link or button for each line in the station details window's lines serving stop list that would open the line management window for that particular line which button or link is clicked. That way you would not need to open the line management window first and the search for the line you want to change.

How does it sound?
Title: Re: Link to line management from station/stop details window
Post by: VS on January 09, 2009, 08:20:36 AM
There is a tool for changing all schedule... can't remember since when exactly. Click old platform, click new platform. It should be in special tools if it's in the version you play.
Title: Re: Link to line management from station/stop details window
Post by: Combuijs on January 09, 2009, 08:32:38 AM
QuoteI needed to change destination platform for several lines serving one particular station

QuoteThere is a tool for changing all schedule

The tool is there, VS, and it's very useful, but I don't think that's what he wants. Going directly to a line from that window would be handy, but there are some difficulties. For example, all lines are shown, also lines from other players. And you can't go to edit these. But all and all, it would be a really useful extension.
Title: Re: Link to line management from station/stop details window
Post by: Simppe on January 09, 2009, 08:45:30 AM
Quote from: Combuijs on January 09, 2009, 08:32:38 AMGoing directly to a line from that window would be handy
That was the point.

Quote from: Combuijs on January 09, 2009, 08:32:38 AMFor example, all lines are shown, also lines from other players. And you can't go to edit these.
Couldn't that be handled so that only the lines of the current player has this link/button?

Edit: Btw, I'm using Simutrans 100.0 (r1867)
Title: Re: Link to line management from station/stop details window
Post by: VS on January 09, 2009, 08:52:55 AM
Oh, I see. I thought it was that you have to look at station, look at lines, look at schedules, compare coordinates...
Title: Re: Link to line management from station/stop details window
Post by: emaxectranspoorte on January 09, 2009, 09:43:33 AM
Quote from: VS on January 09, 2009, 08:52:55 AM
Oh, I see. I thought it was that you have to look at station, look at lines, look at schedules, compare coordinates...

MEE TOO. ;) :)
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 09, 2009, 07:21:13 PM
Quote from: Simppe on January 09, 2009, 08:45:30 AM
Couldn't that be handled so that only the lines of the current player has this link/button?

And also printing the line name with the color of the owner would be handy for multiplayer.
Title: Re: Link to line management from station/stop details window
Post by: VS on January 09, 2009, 07:31:00 PM
Umhhmmm, that really depends on background. Anywhere you put a colour, a square of the colour with some border around is better than text. If you want to make it bulletproof, black and white lines simulating 3d feel are perfect. Only a pattern of the same lines defeats that.
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 14, 2009, 05:20:25 AM
A somewhat first version of a patch to do this.  Lines are colored, buttons are created only for current player's lines, lines are identified when buttons pushed, but left:
Title: Re: Link to line management from station/stop details window
Post by: vilvoh on January 14, 2009, 08:00:50 AM
I support this idea, but watching the attached image in detail I have one doubt. Does this window have a max size? I mean, people usually create a lot of service lines, so easilly you can have no less then 10-15 lines serving in a stop. Therefore, the window may take more and more space and that may become a problem. Wouldn't be possible to use scrolling if the number of lines serving exceed a certain limit, let's say 10 lines?
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 15, 2009, 03:23:45 AM
That's independent from the patch.  I don't know how scrolling is implemented.  I guess it should no be difficult, but I don't know.
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 16, 2009, 02:16:53 AM
This version of the patch should do it.  The only way I found to make the links to the lines change was to implement a virtual method for all opens windows to be notified when active player changes.  That method perhaps can also be used to make changes to some windows of even auto-close them when active player changes.
Title: Re: Link to line management from station/stop details window
Post by: prissi on January 16, 2009, 09:38:34 AM
YOu can check in zeichnen, if a player has change too.
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 16, 2009, 07:54:08 PM
Corrected.  Much cleaner approach...
Title: Re: Link to line management from station/stop details window
Post by: prissi on January 17, 2009, 08:57:16 PM
In trunk: However, I have some problem with using those buttons as UI; in principle color button would have been needed there.
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 18, 2009, 02:50:27 AM
I've also noticed that the line is selected in the tabs window...  Thanx.
Title: Re: Link to line management from station/stop details window
Post by: z9999 on January 18, 2009, 07:22:34 PM
Is it possible to add same button on vehicle window, too ?


[attachment deleted by admin]
Title: Re: Link to line management from station/stop details window
Post by: prissi on January 18, 2009, 07:47:33 PM
Should be easy too ...

EDIT: done (isn't it 4am in Japan?)
Title: Re: Link to line management from station/stop details window
Post by: ij on January 21, 2009, 09:54:22 PM
Grr, I was supposed to implement this, I had even some lines of code written already... :-) Maybe I'll just have to settle on working with something less challenging things such as threading passanger generation and route finding to take advantage of the second core I have there... :-/

Thanks anyway, it's really a desperately needed feature for any decently sized network that needs to be expanded.

In addition to the linking I would want to see also the type(s) of vehicles that are serving on a particular line in order to pick the mail line on the first click.
Title: Re: Link to line management from station/stop details window
Post by: isidoro on January 22, 2009, 12:27:21 AM
My fault.   ;D

If you are working on something, open a thread so that we all know and can focus our efforts on different things...