The International Simutrans Forum

Development => Bug Reports => Topic started by: HDomos on June 11, 2013, 01:57:15 PM

Title: r6538 elevated ways over water disappeared
Post by: HDomos on June 11, 2013, 01:57:15 PM
When i first loaded the game yesterday it worked just fine, but today when i loaded it, all the elevated ways placed on water just disappeared. See images attached.
(https://lh3.googleusercontent.com/-wTMWXypeAFc/UbcsBLD6LnI/AAAAAAAAL8A/ay25fPidEtc/w1118-h650-no/simscr08.jpg)
(https://lh5.googleusercontent.com/-8qev5Xt7yRs/Ubcr-i9s8xI/AAAAAAAAL74/i3COwaaRl3M/w1118-h650-no/simscr09.jpg)
Title: Re: r6538 elevated ways over water disappeared
Post by: greenling on June 11, 2013, 02:48:13 PM
Hello HDomos
can you try to post this bug in the german forum too?
The chiefprogrammer there lighter to reach.
Title: Re: r6538 elevated ways over water disappeared
Post by: kierongreen on June 11, 2013, 10:27:47 PM
Confirmed.
Title: Re: r6538 elevated ways over water disappeared
Post by: Dwachs on June 12, 2013, 06:13:22 AM
Quote from: greenling on June 11, 2013, 02:48:13 PM
The chiefprogrammer there lighter to reach.
This is simply not true.
Title: Re: r6538 elevated ways over water disappeared
Post by: kierongreen on June 13, 2013, 07:15:47 AM
Very simple fix!


Index: boden/grund.cc
===================================================================
--- boden/grund.cc    (revision 6543)
+++ boden/grund.cc    (working copy)
@@ -185,7 +185,7 @@
     // water saves its correct height => no need to save grid heights anymore
     sint8 z = welt->lookup_hgt( pos.get_2d() ); // save grid height for water tiles - including partial water tiles
     sint8 z_w = welt->get_water_hgt( pos.get_2d() );
-    if(  (!ist_wasser()  &&  z > z_w)  ||  ist_bruecke()  ||  ist_tunnel()  ) {
+    if(  (!ist_wasser()  &&  z > z_w)  ||  ist_bruecke()  ||  ist_tunnel()  ||  get_typ() == grund_t::monorailboden  ) {
         z = pos.z; // all other tiles save ground height
     }


Title: Re: r6538 elevated ways over water disappeared
Post by: Ters on June 13, 2013, 09:31:57 AM
Looks like there should be an ist_monorail(), perhaps with a more generic name than monorail, possibly also in English. If there already is, use that.
Title: Re: r6538 elevated ways over water disappeared
Post by: kierongreen on June 13, 2013, 05:38:09 PM
There isn't.
Title: Re: r6538 elevated ways over water disappeared
Post by: HDomos on June 13, 2013, 08:07:19 PM
Thanks :)

Quote from: kierongreen on June 13, 2013, 07:15:47 AM
Very simple fix!


Index: boden/grund.cc
===================================================================
--- boden/grund.cc    (revision 6543)
+++ boden/grund.cc    (working copy)
@@ -185,7 +185,7 @@
     // water saves its correct height => no need to save grid heights anymore
     sint8 z = welt->lookup_hgt( pos.get_2d() ); // save grid height for water tiles - including partial water tiles
     sint8 z_w = welt->get_water_hgt( pos.get_2d() );
-    if(  (!ist_wasser()  &&  z > z_w)  ||  ist_bruecke()  ||  ist_tunnel()  ) {
+    if(  (!ist_wasser()  &&  z > z_w)  ||  ist_bruecke()  ||  ist_tunnel()  ||  get_typ() == grund_t::monorailboden  ) {
         z = pos.z; // all other tiles save ground height
     }



Title: Re: r6538 elevated ways over water disappeared
Post by: kierongreen on June 13, 2013, 10:05:51 PM
Fix is in trunk r6547