The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: whoami on December 03, 2013, 03:12:25 AM

Title: [r6949] cannot build tunnel from portal only
Post by: whoami on December 03, 2013, 03:12:25 AM
I just noticed (with pak64 r1336) that it is possible to build a tunnel portal when the tile behind it is already a tunnel tile (which was prevented before). Nice, I thought, this is something I had hoped for. But it does not work as expected: the new portal is not attached to the tunnel network, and it cannot be attached by the tunnel tools no matter what. Generally, a portal (only the entrance tile), that has no contact to a tunnel tile, cannot be connected to one. I seem to remember that this had worked in the past. Instead, now, it has to be rebuilt, needing a second free tile behind the slope.

I refer only to tunnels of the same waytype, I tested train tracks.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: prissi on December 03, 2013, 11:18:20 PM
I though nobody touched the tunnelbauer this year, so this may be already there for a longer time.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: Dwachs on December 04, 2013, 08:21:57 PM
Tunnel mouth will now be connected to existing tile behind. In fact, tunnels will now always connect to already existing tunnel tiles and tunnel building will not fail in such a case (r 6959).

Edit:
Connecting tunnel mouths to the tunnel network should work in r 6960, too.

However, I am not sure whether the change in r6959 is double-height safe.

Edit2: tunnels will not connect right if tunnel slopes are there. Will fix this later.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: whoami on December 06, 2013, 12:05:43 AM
It is now much better, even better than before the glitch showed up: single portals will be built if a tunnel is found (that would be crossed), connections happen automatically, an opposite single portal connects to the existing one (unless there are other tunnel tiles in between).

If it's not an effort, I would just suggest to also allow to build a tunnel between two isolated portals in one dragging action, which now is prevented.

And an extension/change request: as very large tunnel systems are possible nowadays, I suggest that only control-click on a portal with the deletion tool should remove the entire structure, whereas simple click should remove only the portal.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: Ters on December 06, 2013, 05:56:09 AM
Quote from: whoami on December 06, 2013, 12:05:43 AM
And an extension/change request: as very large tunnel systems are possible nowadays, I suggest that only control-click on a portal with the deletion tool should remove the entire structure, whereas simple click should remove only the portal.

The problem is that players who do not yet know advanced tunnel building and underground mode, but only straight through tunnels, will then only remove the portals, leaving the rest of the tunnel in place. If the tunnel is long, this would leave a lingering, huge, unexplained money drain. Maybe it's better to simply have the simple click removal refuse to remove the structure if it is branching, forcing use of control+click to remove portals on advanced tunnel systems.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: whoami on December 06, 2013, 01:22:09 PM
Quote from: Ters on December 06, 2013, 05:56:09 AM
Maybe it's better to simply have the simple click removal refuse to remove the structure if it is branching, forcing use of control+click to remove portals on advanced tunnel systems.
Oh yes, that is an even better way.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: prissi on December 06, 2013, 01:54:00 PM
My suggestions: If crossconnected, then fail with error message "This tunnel branches. You can try Control+Click to remove". It will still fail if there are Depots with vehicles and stuff.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: whoami on December 16, 2013, 02:05:08 PM
Quote from: prissi on December 06, 2013, 01:54:00 PM
My suggestions: If crossconnected, then fail with error message "This tunnel branches. You can try Control+Click to remove". It will still fail if there are Depots with vehicles and stuff.
I like this proposal.
Title: Re: [r6949] cannot build tunnel from portal only
Post by: Fabio on December 16, 2013, 05:51:48 PM
I like it too


Sent from my iPhone using Tapatalk (http://tapatalk.com/m?id=1)
Title: Re: [r6949] cannot build tunnel from portal only
Post by: prissi on December 18, 2013, 10:39:33 AM
Added in -r6990