The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: Zeno on December 06, 2013, 09:36:05 AM

Title: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on December 06, 2013, 09:36:05 AM
By the way, after a vehicle upgrade using the replace vehicle dialog, the old vehicle remains at the depot after upgrading. I guess this is not the desired way of doing business, is it?  8)
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on December 06, 2013, 09:03:03 PM
Thank you for the report on this: I have split this into a separate topic so that I can keep it for reference when I get time to look into the bug.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on December 06, 2013, 10:58:50 PM
No problem. Btw, I have same behavior in case of simple replacing, without upgrading the vehicle.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on December 21, 2013, 11:54:17 PM
Hmm - can't reproduce this, I am afraid. Can you give any more detailed steps to reproduce?
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on December 22, 2013, 07:53:21 PM
Well, there are no steps... I just replace a vehicle, and it replaces properly. But when I open the depot I see there the replaced vehicle there instead of being sold. Again, I'm playing with a non-exp pakset, dunno if that can affect.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on December 22, 2013, 08:45:22 PM
You do realise that there is an option in the replacer window for vehicles to remain in the depot? In your original post, you suggested that this was only happening with upgrades and also occurred when a vehicle was upgraded in the depot without use of the replacer; can you verify whether this is just you using the option in the replacer window to retain replaced vehicles or whether this is a bug?

Thank you for the report!
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on December 22, 2013, 09:19:12 PM
No, I'm not using that option; at least I don't check it, and it looks like unchecked by default. I'm attaching a couple of screenshots, the replace screen and the vehicle after the replace is done.

In addition, I left a saved game here (http://simutrans-germany.com/files/upload/replace_bug.7z). I used pak128.Britain-Exp 0.9.0 and successfully reproduced it. You will see a horse in the stable, which is result of replacing it by a different vehicle.

Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on December 22, 2013, 09:32:46 PM
Thank you for the saved game - that should be helpful. Is that the normal Pak128 that you are using?

I am now away at my parents' for Christmas, and will not be able to do anything with this until I get back to my normal computer, but thank you for the report!
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on December 22, 2013, 09:47:46 PM
No problem, James, we're not in a hurry. And I guess the bug won't go anywhere for Christmas :D
By the way, I use pak128 standard, plus some experimentalised spanish addon vehicles.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on January 12, 2014, 01:59:37 PM
I have now returned home and have begun to look into these bugs, but I am afraid that your saved game appears to have vanished. Would you mind uploading it again? I should be most grateful.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on January 12, 2014, 03:57:45 PM
Done! Please, use the same link above.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on January 12, 2014, 04:29:03 PM
Thank you for uploading that. I see the horse in the depot, but when I start a replace operation myself, I cannot reproduce this error. Can you post a screenshot of the replace window just before you press "Full replace" to let me know your exact settings?
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: Zeno on January 12, 2014, 04:41:53 PM
Here you are. I also attached the settings-experimental.xml file, just in case it might be useful.
Title: Re: [11.13] Old vehicle remains in depot after upgrade
Post by: jamespetts on January 12, 2014, 05:19:07 PM
Very odd - still can't reproduce this.